From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZjS5w-00031T-I1
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 09:15:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZjS5t-0001GX-Bo
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 09:15:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42341)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZjS5t-0001G7-6s
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 09:15:49 -0400
References: <016801d10034$6356fe40$2a04fac0$@samsung.com>
	<5613C659.5070108@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5613C97E.3030505@redhat.com>
Date: Tue, 6 Oct 2015 15:15:42 +0200
MIME-Version: 1.0
In-Reply-To: <5613C659.5070108@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qobject: Replace property list with
 GHashTable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>, David Gibson <dgibson@redhat.com>
Cc: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org



On 06/10/2015 15:02, Laszlo Ersek wrote:
>>  void object_unparent(Object *obj)
>>  {
>>      if (obj->parent) {
>> -        object_property_del_child(obj->parent, obj, NULL);
>> +        g_hash_table_foreach_remove(obj->properties,

This should be obj->parent->properties.

Otherwise, the patch looks good.

Paolo

>> +                                    object_property_del_child, obj);
>>      }
>>  }