From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjSSH-00005r-Pn for qemu-devel@nongnu.org; Tue, 06 Oct 2015 09:39:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjSSE-0007T4-Jy for qemu-devel@nongnu.org; Tue, 06 Oct 2015 09:38:57 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:18828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjSSE-0007Ss-Dz for qemu-devel@nongnu.org; Tue, 06 Oct 2015 09:38:54 -0400 References: <1444037606-15202-1-git-send-email-yongbok.kim@imgtec.com> From: Leon Alrae Message-ID: <5613CEEC.804@imgtec.com> Date: Tue, 6 Oct 2015 14:38:52 +0100 MIME-Version: 1.0 In-Reply-To: <1444037606-15202-1-git-send-email-yongbok.kim@imgtec.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: Add SIGRIE instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yongbok Kim , qemu-devel@nongnu.org Cc: aurelien@aurel32.net On 05/10/15 10:33, Yongbok Kim wrote: > @@ -18958,6 +18964,10 @@ static void decode_opc(CPUMIPSState *env, DisasContext *ctx) > check_insn_opc_removed(ctx, ISA_MIPS32R6); > gen_trap(ctx, op1, rs, -1, imm); > break; > + case OPC_SIGRIE: > + check_insn(ctx, ISA_MIPS32R6); > + generate_exception_err(ctx, EXCP_RI, extract32(ctx->opcode, 0, 16)); Code field is passed as the error_code, but it isn't used later anywhere and just causes confusion. MIPS BIS document doesn't require any specific behaviour related to this field, thus in QEMU we should ignore it and just call generate_exception_end(ctx, EXCP_RI) here. Leon