From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zjfpg-0002cW-M3 for qemu-devel@nongnu.org; Tue, 06 Oct 2015 23:56:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zjfpb-0005Mg-K5 for qemu-devel@nongnu.org; Tue, 06 Oct 2015 23:55:59 -0400 Received: from [59.151.112.132] (port=51059 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zjfpb-0005Lv-48 for qemu-devel@nongnu.org; Tue, 06 Oct 2015 23:55:55 -0400 Message-ID: <561497BA.3090906@cn.fujitsu.com> Date: Wed, 7 Oct 2015 11:55:38 +0800 From: Yang Hongyang MIME-Version: 1.0 References: <1443429426-10488-1-git-send-email-yanghy@cn.fujitsu.com> <87zj03sszk.fsf@blackfin.pond.sub.org> <56147681.9060505@cn.fujitsu.com> In-Reply-To: <56147681.9060505@cn.fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 00/10] Add a netfilter object and netbuffer filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 10/07/2015 09:33 AM, Yang Hongyang wrote: > > > On 10/01/2015 01:43 AM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> This patch add an netfilter abstract object, captures all network packets >>> on associated netdev. Also implement a concrete filter buffer based on >>> this abstract object. the "buffer" netfilter could be used by VM FT solutions >>> like MicroCheckpointing, to buffer/release packets. Or to simulate >>> packet delay. >>> >>> You can also get the series from: >>> https://github.com/macrosheep/qemu/tree/netfilter-v12 >>> >>> Usage: >>> -netdev tap,id=bn0 >>> -device e1000,netdev=bn0 >>> -object filter-buffer,id=f0,netdev=bn0,queue=rx,interval=1000 >>> >>> dynamically add/remove netfilters: >>> object_add filter-buffer,id=f0,netdev=bn0,queue=rx,interval=1000 >>> object_del f0 >>> >>> NOTE: >>> interval is in microseconds and can't be omiited. >>> queue is optional, and is one of rx|tx|all, default is "all". See >>> enum NetFilterDirection for detail. >> >> I reviewed the patches touching the QAPI schema or the command line. >> Only a few simple issues left. One more respin should do it. >> . >> > > Thanks, will do. Hi Markus, I've already addressed all your comments on v12 and send out a v13. Could you please review the last bits, thanks very much. > > -- Thanks, Yang.