From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZjkMz-0000Lv-6G
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 04:46:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZjkMv-0003nZ-68
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 04:46:41 -0400
Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:37808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZjkMu-0003nM-VF
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 04:46:37 -0400
Received: by wicfx3 with SMTP id fx3so17602554wic.0
	for <qemu-devel@nongnu.org>; Wed, 07 Oct 2015 01:46:36 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1444161658-15038-1-git-send-email-pbonzini@redhat.com>
	<1444161658-15038-4-git-send-email-pbonzini@redhat.com>
	<22126.3941414238$1444205724@news.gmane.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5614DBE7.2050506@redhat.com>
Date: Wed, 7 Oct 2015 10:46:31 +0200
MIME-Version: 1.0
In-Reply-To: <22126.3941414238$1444205724@news.gmane.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org



On 07/10/2015 10:14, Pavel Dovgaluk wrote:
> > It doesn't seem correct to call it for all checkpoints, but why
> > is it right for timerlist_run_timers?
> 
> Because replaying shouldn't proceed when machine is stopped.

Right, but VIRTUAL and VIRTUAL_RT do not proceed when the machine is
stopped.  For HOST it makes sense, but then the same should happen
independent of the replay mode (using qemu_clock_enable).

Otherwise, if a checkpoint for the wrong clock sneaks in at the wrong
point while the VM is running, I wonder if replay could grind to a halt.

Paolo

> These checks could be also useful for creating snapshots in record mode,
> but I don't remember exact reasons of adding them. I'll check your changes 
> for the current version.