From: Richard Henderson <rth@twiddle.net>
To: Chen Gang <xili_gchen_5257@hotmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Chris Metcalf <cmetcalf@ezchip.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly
Date: Wed, 7 Oct 2015 20:18:16 +1100 [thread overview]
Message-ID: <5614E358.1020708@twiddle.net> (raw)
In-Reply-To: <COL130-W409A3086A95486ECC1570DB9490@phx.gbl>
On 10/04/2015 10:13 PM, Chen Gang wrote:
>>From 0f53a45b3c29e3355cc6b2183ee084e62b86e5fe Mon Sep 17 00:00:00 2001
> From: Chen Gang<gang.chen.5i5j@gmail.com>
> Date: Sun, 4 Oct 2015 13:34:33 +0800
> Subject: [PATCH v2] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly
>
> For some cases, they are for TILEGX_EXCP_OPCODE_UNKNOWN, not for
> TILEGX_EXCP_OPCODE_UNIMPLEMENTED.
>
> Also for some cases, they are for TILEGX_EXCP_OPCODE_UNIMPLEMENTED, not
> for TILEGX_EXCP_OPCODE_UNKNOWN.
>
> When analyzing issues, the correct printing information is necessary,
> e.g. grep UIMP in gcc testsuite output log for finding qemu tilegx
> umimplementation issues, grep UNKNOWN for finding unknown instructions.
>
> Signed-off-by: Chen Gang<gang.chen.5i5j@gmail.com>
> ---
> target-tilegx/translate.c | 41 ++++++++++++++++++++++++-----------------
> 1 file changed, 24 insertions(+), 17 deletions(-)
Applied.
r~
next prev parent reply other threads:[~2015-10-07 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 11:13 [Qemu-devel] [PATCH v2] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly Chen Gang
2015-10-07 9:18 ` Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-04 11:01 [Qemu-devel] [PATCH v2] target-tilegx: Implement v2sh* instructions gang.chen.5i5j
2015-10-04 11:01 ` [Qemu-devel] [PATCH v2] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly gang.chen.5i5j
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614E358.1020708@twiddle.net \
--to=rth@twiddle.net \
--cc=cmetcalf@ezchip.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).