From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40091)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zjkrm-0002j6-Fp
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:18:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zjkrh-0002tQ-FJ
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:18:30 -0400
Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]:33658)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zjkrh-0002t9-9T
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:18:25 -0400
Received: by pacex6 with SMTP id ex6so16128799pac.0
	for <qemu-devel@nongnu.org>; Wed, 07 Oct 2015 02:18:24 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <COL130-W409A3086A95486ECC1570DB9490@phx.gbl>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <5614E358.1020708@twiddle.net>
Date: Wed, 7 Oct 2015 20:18:16 +1100
MIME-Version: 1.0
In-Reply-To: <COL130-W409A3086A95486ECC1570DB9490@phx.gbl>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] target-tilegx: Use
 TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <xili_gchen_5257@hotmail.com>, Peter Maydell <peter.maydell@linaro.org>, Chris Metcalf <cmetcalf@ezchip.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 10/04/2015 10:13 PM, Chen Gang wrote:
>>>From 0f53a45b3c29e3355cc6b2183ee084e62b86e5fe Mon Sep 17 00:00:00 2001
> From: Chen Gang<gang.chen.5i5j@gmail.com>
> Date: Sun, 4 Oct 2015 13:34:33 +0800
> Subject: [PATCH v2] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly
>
> For some cases, they are for TILEGX_EXCP_OPCODE_UNKNOWN, not for
> TILEGX_EXCP_OPCODE_UNIMPLEMENTED.
>
> Also for some cases, they are for TILEGX_EXCP_OPCODE_UNIMPLEMENTED, not
> for TILEGX_EXCP_OPCODE_UNKNOWN.
>
> When analyzing issues, the correct printing information is necessary,
> e.g. grep UIMP in gcc testsuite output log for finding qemu tilegx
> umimplementation issues, grep UNKNOWN for finding unknown instructions.
>
> Signed-off-by: Chen Gang<gang.chen.5i5j@gmail.com>
> ---
>   target-tilegx/translate.c | 41 ++++++++++++++++++++++++-----------------
>   1 file changed, 24 insertions(+), 17 deletions(-)


Applied.


r~