From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjqHL-0002ce-Tz for qemu-devel@nongnu.org; Wed, 07 Oct 2015 11:05:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjqHG-00072B-2j for qemu-devel@nongnu.org; Wed, 07 Oct 2015 11:05:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjqHF-00071y-TY for qemu-devel@nongnu.org; Wed, 07 Oct 2015 11:05:10 -0400 References: <5614531B.5080107@redhat.com> <1444198846-5383-1-git-send-email-den@openvz.org> <1444198846-5383-4-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <561534A4.1070306@redhat.com> Date: Wed, 7 Oct 2015 09:05:08 -0600 MIME-Version: 1.0 In-Reply-To: <1444198846-5383-4-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8QiTe78nQRxWBD355K0saxlDNgCTgFbvi" Subject: Re: [Qemu-devel] [PATCH 3/8] migration: add new capability test-only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Igor Redko , jsnow@redhat.com, qemu-devel@nongnu.org, annam@virtuozzo.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8QiTe78nQRxWBD355K0saxlDNgCTgFbvi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/07/2015 12:20 AM, Denis V. Lunev wrote: > From: Igor Redko >=20 > This patch declares a new migration capability that allows > to distinguish between true migration and the test. >=20 > An alternative is using a custom URI but in this case the > following problems should be solved: > 1/ QEMUFile abstraction hides the real transport type > 2/ We must be ensured that VM will not be stopped due to > =E2=80=9Csuccessful migration=E2=80=9D >=20 > Possible solutions: > 1/ Using global variable analogous to > s->enabled_capabilities[MIGRATION_CAPABILITY_TEST_ONLY] that > will be initialized according to the migration type at the > beginning of the migration process > 2/ Additional hook, presence of implementation of which allows > to decide whether the migration is true >=20 Do we want to name the capability 'x-test-only', since this series is experimental, to make it obvious that production code should not rely on = it? > +++ b/qapi-schema.json > @@ -540,11 +540,14 @@ > # @auto-converge: If enabled, QEMU will automatically throttle down th= e guest > # to speed up convergence of RAM migration. (since 1.6) > # > +# @test-only: If enabled, QEMU instead of migrating will estimate migr= ation > +# time basing on given downtime and current dirty page rate If we do decide to add this to mainline, it would need 'since 2.5' (or whatever version) documentation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8QiTe78nQRxWBD355K0saxlDNgCTgFbvi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWFTSkAAoJEKeha0olJ0NqxLEH/348fXPDtxr41jLsAf9zppLc N8PPCp233a6LyvzSznHUHVBUobKb5NgZ2Vnr5znIUqhj5E0dEfeqq0OVv57AKVXH QKRxY46Q0OA+1YzX+YC+rYX73dqT8oi7ac5agd2eCLQJBSqTceE0EyRcBDked2M9 XUtUeXwcYYXuFRDwk/JQhJ72RKLzF8WuXm0HC0rDLS3iNUW8hWBOIRQWOoGF9WEq BSpVsoYz0NrQcuctrnTFfq29tWe2qAdzI5tTmM1dLEqL3TdWrCow7X/sEW8zK3IT VnUAAw/DK9CHyZntHkjpmxOI/ynDGZmRIMc7bR5p3ymbodhnmciZ1yLbNmV9HYU= =3LFI -----END PGP SIGNATURE----- --8QiTe78nQRxWBD355K0saxlDNgCTgFbvi--