From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjqKY-00052I-J7 for qemu-devel@nongnu.org; Wed, 07 Oct 2015 11:08:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjqKU-0000OW-SV for qemu-devel@nongnu.org; Wed, 07 Oct 2015 11:08:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjqKU-0000OL-NE for qemu-devel@nongnu.org; Wed, 07 Oct 2015 11:08:30 -0400 References: <5614531B.5080107@redhat.com> <1444198846-5383-1-git-send-email-den@openvz.org> <1444198846-5383-8-git-send-email-den@openvz.org> <20151007135653.GF2710@work-vm> From: Eric Blake Message-ID: <5615356D.7030408@redhat.com> Date: Wed, 7 Oct 2015 09:08:29 -0600 MIME-Version: 1.0 In-Reply-To: <20151007135653.GF2710@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5JXERKeM4xDMtt6vBjSBeU2reCjpPoEuU" Subject: Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , "Denis V. Lunev" Cc: Igor Redko , quintela@redhat.com, annam@virtuozzo.com, qemu-devel@nongnu.org, amit.shah@redhat.com, jsnow@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5JXERKeM4xDMtt6vBjSBeU2reCjpPoEuU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/07/2015 07:56 AM, Dr. David Alan Gilbert wrote: > * Denis V. Lunev (den@openvz.org) wrote: >> From: Igor Redko >> >> In this patch the ability to start a migration with test-only >> capability was added. It allows to gather the guest VM=E2=80=99s memor= y >> usage statistics avoiding time and memory overheads and real >> data transmission. New MIGRATION_STATUS_TEST_COMPLETED was >> added to distinguish between test migration and true migration >> success states. >=20 > Why isn't this just a new transport? i.e. I could do this just by doing= > a migrate to test: ? >=20 > It seems simpler and avoids some of the special casing? Indeed. Even if the new state can only be triggered by using a new option, the fact that the new state exists in introspection means clients have to figure out what to do with it; while a new transport would not require any new states ("running" to completion means that nothing migrated, but the existing states can then be reused to see that the test: transport has finished computing its numbers). >> +++ b/qapi-schema.json >> @@ -432,6 +432,8 @@ >> # >> # @completed: migration is finished. >> # >> +# @test-completed: migration time estimation finished. >> +# If this gets added, in spite of our ideas to use a 'test:' transport instead of a new state, it would need a 'since 2.5' marker. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5JXERKeM4xDMtt6vBjSBeU2reCjpPoEuU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWFTVtAAoJEKeha0olJ0Nq3fMIAJENf1zmmFm6bFLWfFsqte4r bPlwfPFtIvMyY38uAk5ie8S8LybzW0LVzaUQLr5ar0swqtih4Tj6L5hQDIuVQ3Lb 9nAH6R2yRAUXUPVgMy2cWIkZ/NLKrGL+4i4rbbTxFnS3M7RjynCL1oc0trQ7FQ+H umIPuWgaYKIhXRh8IrlK8K8y3D1TkkB8PGjfl7ieetCDBleMJ7h93Hng5iZj/zhK 6sfi3u4n1iGnGbZoEySiU8tF26A6q4ehRDBadUcLOHYRgfO1DDSY0CDuHXSNE89S cwQ962TmFCtbNz9MGtFfZ+Ir841VgyDmlSAeT+WjVPS+TGDoJI1uEeHS73uj0MQ= =wU3Y -----END PGP SIGNATURE----- --5JXERKeM4xDMtt6vBjSBeU2reCjpPoEuU--