From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zjreb-0002bj-JF for qemu-devel@nongnu.org; Wed, 07 Oct 2015 12:33:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjreW-00027p-L3 for qemu-devel@nongnu.org; Wed, 07 Oct 2015 12:33:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjreW-00027d-DQ for qemu-devel@nongnu.org; Wed, 07 Oct 2015 12:33:16 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 18E4319F228 for ; Wed, 7 Oct 2015 16:33:15 +0000 (UTC) References: <1443930073-19359-1-git-send-email-eblake@redhat.com> <1443930073-19359-4-git-send-email-eblake@redhat.com> <87wpuywt89.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56154945.5020107@redhat.com> Date: Wed, 7 Oct 2015 10:33:09 -0600 MIME-Version: 1.0 In-Reply-To: <87wpuywt89.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tHMWT9JLTxMMGOKlM5OphXeOPf5cXI6bX" Subject: Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tHMWT9JLTxMMGOKlM5OphXeOPf5cXI6bX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/07/2015 10:15 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> The alternate-good.json test was already covered by >> qapi-schema-test.json. As future commits will be tweaking >> how alternates are laid out, removing the duplicate test now >> reduces churn. >=20 > Do we have more positive tests? They should probably all live in > qapi-schema-test.json, because there their generated code actually gets= > compiled. Hmm, any test that has an empty .err and non-empty .out, but which does not also have an TODO/FIXME stating that it is a bug, is worth checking. So first, here's the list of non-empty .out files: empty.out [1] enum-empty.out event-case.out [4] union-empty.out [2] include-simple.out include-repetition.out include-relpath.out comments.out alternate-empty.out [2] returns-int.out struct-base-clash-base.out [3] flat-union-empty.out [2] indented-expr.out union-clash-data.out [3] ident-with-escape.out args-member-array.out flat-union-reverse-define.out [1] must stay separate, because we can't really make qapi-schema-test empty :) [2] marked FIXME, and turns into proper error message later in the v5 ser= ies [3] marked FIXME, and already removed later in the v5 series once a positive test is inlined into qapi-schema-test [4] marked TODO For the ones I didn't tag with a footnote, we could probably cover things directly in qapi-schema-test instead; the question then becomes which ones are already covered, and which ones need content moved. >=20 > Patch looks good. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tHMWT9JLTxMMGOKlM5OphXeOPf5cXI6bX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWFUlFAAoJEKeha0olJ0NqU5gH/3SGV1kgYjNcqO7exHaPL9Es Naf94XqnfTKSGbiMUfLHmgoBPY2KUt/DScaSD0TKyJQ743gXgfaKqtiQomu8uUXU Dt2uWa+oOW+sV8AwoOVCv0TtfDym5fiIGq7sR5HSNrHfQaC1qs0otdQnWCCkILz+ d4//aqDHE1iy5UJ9U+urlMu/3kfgUp0AnS2NuCaTmRo1zf41cMptMwL/hss6fgcN 20X5dWFP5WqItsq46Q34sbX4gFo5WRysW0kmBYUhkHYY0yHfUQRnTvWt7uuKHWbz pluOsSd9TfGhUSuyHD0H1N9CHbsnMrgFt7SxYn+vIkj9jMP2/BlWGVHhLoaRrv8= =wxJM -----END PGP SIGNATURE----- --tHMWT9JLTxMMGOKlM5OphXeOPf5cXI6bX--