Re: [Qemu-devel] [PATCH v2 04/16] quorum: Convert to BdrvChild

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On 01.10.2015 15:13, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/quorum.c | 63 ++++++++++++++++++++++++++++++----------------------------
>  1 file changed, 33 insertions(+), 30 deletions(-)
> 
> diff --git a/block/quorum.c b/block/quorum.c
> index 8fe53b4..c4cda32 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c

[...]

> @@ -923,7 +924,7 @@ static int quorum_open(BlockDriverState *bs, QDict *options, int flags,
>      }
>  
>      /* allocate the children BlockDriverState array */

Just noticed when looking at some other series: This comment is now stale.

Max

> -    s->bs = g_new0(BlockDriverState *, s->num_children);
> +    s->children = g_new0(BdrvChild *, s->num_children);
>      opened = g_new0(bool, s->num_children);
>  
>      for (i = 0; i < s->num_children; i++) {



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]