From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjtH5-0001la-Ey for qemu-devel@nongnu.org; Wed, 07 Oct 2015 14:17:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjtGz-0005PX-Jb for qemu-devel@nongnu.org; Wed, 07 Oct 2015 14:17:11 -0400 References: <1443705214-9304-1-git-send-email-kwolf@redhat.com> <1443705214-9304-5-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56156196.90605@redhat.com> Date: Wed, 7 Oct 2015 20:16:54 +0200 MIME-Version: 1.0 In-Reply-To: <1443705214-9304-5-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HjiLI7uvq3HAOKBw7t455Xn09MRBSffJp" Subject: Re: [Qemu-devel] [PATCH v2 04/16] quorum: Convert to BdrvChild List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: jcody@redhat.com, berto@igalia.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HjiLI7uvq3HAOKBw7t455Xn09MRBSffJp Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 01.10.2015 15:13, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > Reviewed-by: Alberto Garcia > --- > block/quorum.c | 63 ++++++++++++++++++++++++++++++--------------------= -------- > 1 file changed, 33 insertions(+), 30 deletions(-) >=20 > diff --git a/block/quorum.c b/block/quorum.c > index 8fe53b4..c4cda32 100644 > --- a/block/quorum.c > +++ b/block/quorum.c [...] > @@ -923,7 +924,7 @@ static int quorum_open(BlockDriverState *bs, QDict = *options, int flags, > } > =20 > /* allocate the children BlockDriverState array */ Just noticed when looking at some other series: This comment is now stale= =2E Max > - s->bs =3D g_new0(BlockDriverState *, s->num_children); > + s->children =3D g_new0(BdrvChild *, s->num_children); > opened =3D g_new0(bool, s->num_children); > =20 > for (i =3D 0; i < s->num_children; i++) { --HjiLI7uvq3HAOKBw7t455Xn09MRBSffJp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWFWGWAAoJEDuxQgLoOKytUb8H/06hRtfwYxBZrWjC25PUfEcp Vf8HNVFKrsGv/JyCoMTAC5EplL5FMDtduiNCjwZqoa8PcSkHZUqrJ53JHX7ebruH 8+oo1Gp1pmqqg7RUaK5u8A9TyXukGWW82qqNBIdPXE2+CYrPdRxnZaYZVzXzI1wZ fyFz4P3BPG04LK6ZLIGe2vQaqUmlaOeQbhlK6KBnlhZ4nMfisa/qagoNt7JoShKX 63pgydKLxvd0bwVUfMrEjogLsijUfe88LnVAOVJH6gU43VEufETk2zeqHrUwvvD0 XcQlNoSXUbTnyOPfWKGyGQL2TKzebpnZZ1qZ1qY0JnWFunh0tBT5lHtEn+WuW+U= =BEup -----END PGP SIGNATURE----- --HjiLI7uvq3HAOKBw7t455Xn09MRBSffJp--