From: Richard Henderson <rth@twiddle.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: Leon Alrae <leon.alrae@imgtec.com>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ
Date: Thu, 8 Oct 2015 06:54:01 +1100 [thread overview]
Message-ID: <56157859.4070306@twiddle.net> (raw)
In-Reply-To: <20151007103440.GF29862@jhogan-linux.le.imgtec.org>
On 10/07/2015 09:34 PM, James Hogan wrote:
>>> { INDEX_op_brcond_i32, { "rZ", "rZ" } },
>>> +#if !use_mips32r6_instructions
>>> { INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "0" } },
>>> +#else
>>> + { INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "rZ" } },
>>> +#endif
>>
>>
>> The only thing I'd change is preferring positive tests to negative ones. So
>> swap the order of these lines, and the sense of the #if.
>
> No problem. Shall I do a full resend for that, or can it be fixed up by
> whoever applies?
No resend needed. I'll fix it when applying to my tcg queue.
r~
next prev parent reply other threads:[~2015-10-07 19:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 12:24 [Qemu-devel] [PATCH v3 0/6] tcg/mips: Minimal R6 support James Hogan
2015-10-02 12:24 ` [Qemu-devel] [PATCH v3 1/6] tcg-opc.h: Simplify debug_insn_start def James Hogan
2015-10-08 16:12 ` Aurelien Jarno
2015-10-02 12:24 ` [Qemu-devel] [PATCH v3 2/6] disas/mips: Add R6 jr/jr.hb to disassembler James Hogan
2015-10-08 16:12 ` Aurelien Jarno
2015-10-02 12:24 ` [Qemu-devel] [PATCH v3 3/6] tcg/mips: Add use_mips32r6_instructions definition James Hogan
2015-10-08 16:12 ` Aurelien Jarno
2015-10-02 12:24 ` [Qemu-devel] [PATCH v3 4/6] tcg/mips: Support r6 JR encoding James Hogan
2015-10-08 16:15 ` Aurelien Jarno
2015-10-02 12:24 ` [Qemu-devel] [PATCH v3 5/6] tcg/mips: Support r6 multiply/divide encodings James Hogan
2015-10-08 16:19 ` Aurelien Jarno
2015-10-02 12:24 ` [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ James Hogan
2015-10-07 9:46 ` Richard Henderson
2015-10-07 10:34 ` James Hogan
2015-10-07 19:54 ` Richard Henderson [this message]
2015-10-07 11:47 ` Leon Alrae
2015-10-08 16:32 ` Aurelien Jarno
2015-10-08 16:31 ` Aurelien Jarno
2015-10-09 21:26 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56157859.4070306@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=james.hogan@imgtec.com \
--cc=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).