From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkCsQ-0006vs-I0 for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:13:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkCsK-0002Ng-K3 for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:13:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkCsK-0002NZ-En for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:12:56 -0400 References: <1444313344-16196-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <561687F1.7010907@redhat.com> Date: Thu, 8 Oct 2015 09:12:49 -0600 MIME-Version: 1.0 In-Reply-To: <1444313344-16196-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JI6vkIjDEq6MPQsmi5a2rpGHAwQAedAW3" Subject: Re: [Qemu-devel] [PATCH v3 0/5] qom: more efficient object property handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Pavel Fedin , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JI6vkIjDEq6MPQsmi5a2rpGHAwQAedAW3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/08/2015 08:08 AM, Daniel P. Berrange wrote: > This patch series is a combination of my own previous patch to > add support for object properties against classes: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05953.html >=20 > And Pavel Fedin's patch to use a hash table instead of list >=20 > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg01455.html >=20 > I pulled Pavel's patch in to my series, since both our patches > touch the same code and thus generate nasty merge conflicts. >=20 > In resolving these conflicts I decided we needed a new helper > method object_property_foreach to deal with iteration over > properties, hence we now have a short series of patches. >=20 > I made a few changes to Pavel's patch but the guts of it are > still his work, so I left him as GIT author, but removed his > Signed-off-by, since that would not apply to my own additions Actually, I think what is typically done in that case is leaving both Signed-off-by lines (you both have contributions to the final product); often with two-stage commit messages: original comments.... Signed-off-by: person A additional changes... Signed-off-by: person B At any rate, Pavel should have an S-o-B line if he remains git author, regardless of who else also has a S-o-B line. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JI6vkIjDEq6MPQsmi5a2rpGHAwQAedAW3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWFofxAAoJEKeha0olJ0Nqj5MH/0rr3niGRwM5qVT281AVUsNb temU6SZeud/XM0JLNwf1oV1eD8PtAIsgTFTZciyTn7N9OrUuufvRKrllqm/DWmcz PKOM17T2dGoAaHKL5UXemtrPm4H5JvFOXFv1/SzKSHl60dnozoo16uWKa+FkHKwd MNIfjBAIqRvuwVR+EEHySYiwmFVKdSbN05j3UiGvj8gcoPIWcpgP0Vlh7Iukxsiz Qkvzfwc8dIsj0Af09DEmGMtvwdhFC6lcrbKi7+bgfYE+Gww6TvYtRDdoND31E8Tm JuGfkjxY3/LrtEFy5rDWRg5btzdupyoaelbzqGsMoe/3bvn5eAgI+1Si6fuOs4I= =CMcp -----END PGP SIGNATURE----- --JI6vkIjDEq6MPQsmi5a2rpGHAwQAedAW3--