From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkMQ1-00062I-St for qemu-devel@nongnu.org; Thu, 08 Oct 2015 21:24:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkMPz-0007j5-5A for qemu-devel@nongnu.org; Thu, 08 Oct 2015 21:24:21 -0400 Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]:34648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkMPz-0007j1-1R for qemu-devel@nongnu.org; Thu, 08 Oct 2015 21:24:19 -0400 Received: by qgez77 with SMTP id z77so57740448qge.1 for ; Thu, 08 Oct 2015 18:24:17 -0700 (PDT) Message-ID: <56171740.2000809@gmail.com> Date: Thu, 08 Oct 2015 21:24:16 -0400 From: Michael Davidsaver MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Exit on reset for armv7-m List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , "qemu-devel@nongnu.org Developers" On 10/08/2015 04:09 PM, Peter Crosthwaite wrote: > On Thu, Oct 8, 2015 at 8:40 AM, Michael Davidsaver > wrote: >> Implement the SYSRESETREQ bit of the AIRCR register >> for armv7-m (ie. cortex-m3). >> > > This would serve better as the commit message to the patch (which I > notice is missing a commit blurb). Does this warrant sending an updated patch? I would have no objection to whomever applies the patch simply changing the commit message. >> A small patch to see if I have the submission process figured out. >> > > It is usual for the cover and patches to be enumerated together with > the cover being patch 0, e.g. the subject would read [PATCH 0/1]. the > --cover-letter switch of git format-patch does this for you. Alas in this case it did not. Probably because I omitted '--numbered'. >> Michael Davidsaver (1): > > When sending a single, a cover is not required. You could just send > the patch on it's own. This will all be useful when you come to send > multi-patch series however. Noted. Thanks for the feedback Peter. Michael