Re: [Qemu-devel] [PATCH 1/5] hw/dma/pxa2xx: Remove superfluous memset

[Thomas Huth <thuth@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On 08/10/15 22:59, Eric Blake wrote:
> On 10/08/2015 01:35 PM, Thomas Huth wrote:
>> g_malloc0 already clears the memory, so no need for
>> the additional memset here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  hw/dma/pxa2xx_dma.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/dma/pxa2xx_dma.c b/hw/dma/pxa2xx_dma.c
>> index d4501fb..3f0a720 100644
>> --- a/hw/dma/pxa2xx_dma.c
>> +++ b/hw/dma/pxa2xx_dma.c
>> @@ -461,7 +461,6 @@ static int pxa2xx_dma_init(SysBusDevice *sbd)
>>  
>>      s->chan = g_malloc0(sizeof(PXA2xxDMAChannel) * s->channels);
> 
> As long as we're here, this should probably be switched to g_new0(), in
> part to avoid any chance that the multiply can overflow.

Ok, I doubt that we really get overflows here, but g_new0 is certainly
nicer here, so I'll change my patch accordingly.

 Thomas



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]