From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkYk8-0007jN-Sb for qemu-devel@nongnu.org; Fri, 09 Oct 2015 10:33:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkYk5-0002RV-M7 for qemu-devel@nongnu.org; Fri, 09 Oct 2015 10:33:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkYk5-0002Qw-GI for qemu-devel@nongnu.org; Fri, 09 Oct 2015 10:33:53 -0400 References: <1443930073-19359-1-git-send-email-eblake@redhat.com> <1443930073-19359-11-git-send-email-eblake@redhat.com> <87fv1krv1m.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <5617D04F.6040904@redhat.com> Date: Fri, 9 Oct 2015 08:33:51 -0600 MIME-Version: 1.0 In-Reply-To: <87fv1krv1m.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9stK6keAkrTLhjAsahXVmxdE5bwOlf0Do" Subject: Re: [Qemu-devel] [PATCH v7 10/14] qapi: Detect collisions in C member names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9stK6keAkrTLhjAsahXVmxdE5bwOlf0Do Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/09/2015 08:11 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Detect attempts to declare two object members that would result >> in the same C member name, by keying the 'seen' dictionary off >> of the C name rather than the qapi name. It also requires passing >> info through some of the check() methods. >> >> This fixes two previously-broken tests, and the resulting error >> messages demonstrate the utility of the .describe() method added >> previously. No change to generated code. >> >> Signed-off-by: Eric Blake >> >> +++ b/tests/qapi-schema/args-name-clash.err >> @@ -0,0 +1 @@ >> +tests/qapi-schema/args-name-clash.json:5: 'a_b' (member of oops argum= ents) collides with 'a-b' (member of oops arguments) >=20 > "(argument of oops)" would be better, but "(member of oops arguments)" > will do. May be possible to tweak the describe() function in the previous commit along those lines, especially since I'm already tweaking it to not have space in the generated name. I'll have to play with it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9stK6keAkrTLhjAsahXVmxdE5bwOlf0Do Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWF9BPAAoJEKeha0olJ0Nqhk4H/1hlfWU9wjY1Q6kg0yGYLu3Q iBUclEDLmDdccUeSdTBGt79mhiLkfWiDmHbvefU/fSvQ+eiFz5yWmVGNzTM/TLhD 0ukybylfp7rLuUKJsd9pU9aBt5PWa+GlDwBrfJLq5TtZ+99snIzlnsv0HRp2IiMh 8TkEYGsqv60qIO/Uca7sXAOlM2a3e3DQWoyHB2BDzKI0FLG9P2M6IzVagunXBdI1 anOZs1SB0VyocEPv+t1KVfxeBKERxDjGWPdywK3mx9g888prshw5EnVcfq/NPnu5 wdyOKG7YSon9/Vr5Z8M4jwDZmtmTyGCDU36QpFznSAO/vsDdspbX7Gup4NCqHUI= =R/gA -----END PGP SIGNATURE----- --9stK6keAkrTLhjAsahXVmxdE5bwOlf0Do--