From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/4] hw/input/tsc210x: Remove superfluous memset
Date: Fri, 9 Oct 2015 13:13:17 -0600 [thread overview]
Message-ID: <561811CD.5030007@redhat.com> (raw)
In-Reply-To: <1444406198-6521-3-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On 10/09/2015 09:56 AM, Thomas Huth wrote:
> g_malloc0 already clears the memory, so no need for additional
> memsets here. And while we're at it, let's also remove the
> superfluous typecasts for the return values of g_malloc0
> and use the type-safe g_new0 instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/input/tsc210x.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-09 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 15:56 [Qemu-devel] [PATCH v2 0/4] Small optimizations for code using g_malloc0 + memset/memcpy Thomas Huth
2015-10-09 15:56 ` [Qemu-devel] [PATCH v2 1/4] hw/dma/pxa2xx: Remove superfluous memset Thomas Huth
2015-10-09 22:58 ` Eric Blake
2015-10-09 15:56 ` [Qemu-devel] [PATCH v2 2/4] hw/input/tsc210x: " Thomas Huth
2015-10-09 19:13 ` Eric Blake [this message]
2015-10-09 15:56 ` [Qemu-devel] [PATCH v2 3/4] tests/i44fx-test: No need for zeroing memory before memset Thomas Huth
2015-10-09 15:56 ` [Qemu-devel] [PATCH v2 4/4] linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup Thomas Huth
2015-10-12 13:23 ` Riku Voipio
2015-10-29 7:53 ` [Qemu-devel] [PATCH v2 0/4] Small optimizations for code using g_malloc0 + memset/memcpy Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561811CD.5030007@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).