From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkgMU-0000al-R6 for qemu-devel@nongnu.org; Fri, 09 Oct 2015 18:42:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkgMT-00033A-PZ for qemu-devel@nongnu.org; Fri, 09 Oct 2015 18:42:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkgMT-00032k-Km for qemu-devel@nongnu.org; Fri, 09 Oct 2015 18:42:01 -0400 References: <1443930073-19359-1-git-send-email-eblake@redhat.com> <1443930073-19359-5-git-send-email-eblake@redhat.com> <87egh6wsnz.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <561842B3.3010205@redhat.com> Date: Fri, 9 Oct 2015 16:41:55 -0600 MIME-Version: 1.0 In-Reply-To: <87egh6wsnz.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L3U6bnWdQLtGCGG8QO3vVuPeMmwdFfVcT" Subject: Re: [Qemu-devel] [PATCH v7 04/14] qapi: Don't use info as witness of implicit object type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L3U6bnWdQLtGCGG8QO3vVuPeMmwdFfVcT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/07/2015 10:27 AM, Markus Armbruster wrote: >> def visit_needed(self, entity): >> # Visit everything except implicit objects >> - return not isinstance(entity, QAPISchemaObjectType) or entity= =2Einfo >> + return not entity.is_implicit(QAPISchemaObjectType) >=20 > The alternative is something like >=20 > return not (isinstance(entity, QAPISchemaObjectType) and > entity.is_implicit()) >=20 > Trades a more verbose "is this an implicit object type" check for a > simpler is_implicit(). Shorter overall, and feels better to me. But i= f > you feel strongly about your way of doing it, I can live with it. I'm not strongly tied to the concise form enough to stall review, so v8 will use the longer explicit form. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --L3U6bnWdQLtGCGG8QO3vVuPeMmwdFfVcT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWGEKzAAoJEKeha0olJ0NqcrAIAIoqKo4POqu4zZsrluDW/rVf R4z99OoebsEB/akJlMqeSpclf81CEqDkyQBjk4rdddFiq5bVZsUqyJZKkzlevA53 P08SDoSLMQMCbZ8wogjmzxVB9k+Jhy8N9nOe7nwP5IqzTP5oN6MbY+yHa+6Ii55G 4YkbDIiPoJJZ6FZRFZk7JS2O9yGMCqwHPf5pdNwyja07Rc8qHkJph1hMv4yX9tax jU/lTNZWaUnuNK9DhOGKPTIn/Bhxzp4IRBr9mxkoPjZmC33o9/b+7BOd2DNZFoD5 Nmzq7M65dJz+UKRp0B238gqPgOqVRH+zLHLkxizmO9faFMkaN5rQQg5OeQDzJhE= =cRRq -----END PGP SIGNATURE----- --L3U6bnWdQLtGCGG8QO3vVuPeMmwdFfVcT--