qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] aio: Introduce aio-epoll.c
Date: Mon, 12 Oct 2015 12:06:51 +0200	[thread overview]
Message-ID: <561B863B.90006@redhat.com> (raw)
In-Reply-To: <1444643731-15346-4-git-send-email-famz@redhat.com>



On 12/10/2015 11:55, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  Makefile.objs                |   1 +
>  aio-epoll.c                  | 150 +++++++++++++++++++++++++++++++++++++++++++
>  aio-posix.c                  |  16 ++++-
>  include/block/aio-internal.h |  15 +++++
>  include/block/aio.h          |   5 ++
>  stubs/Makefile.objs          |   1 +
>  stubs/aio-epoll.c            |  37 +++++++++++
>  7 files changed, 223 insertions(+), 2 deletions(-)
>  create mode 100644 aio-epoll.c
>  create mode 100644 stubs/aio-epoll.c

aio-epoll.c seems small enough that you can just include everything in
aio-posix.c.  This should simplify everything and make patch 1
unnecessary, too.

Paolo

  reply	other threads:[~2015-10-12 10:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12  9:55 [Qemu-devel] [PATCH 0/3] aio: Use epoll in aio_poll() Fam Zheng
2015-10-12  9:55 ` [Qemu-devel] [PATCH 1/3] aio: Move AioHandler struct to header Fam Zheng
2015-10-12  9:55 ` [Qemu-devel] [PATCH 2/3] aio: Introduce aio_context_setup Fam Zheng
2015-10-12  9:55 ` [Qemu-devel] [PATCH 3/3] aio: Introduce aio-epoll.c Fam Zheng
2015-10-12 10:06   ` Paolo Bonzini [this message]
2015-10-12 11:24     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561B863B.90006@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).