From: Eric Blake <eblake@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Gleb Natapov <gleb@kernel.org>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
rkagan@virtuozzo.com, Andrey Smetanin <asmetanin@virtuozzo.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
Date: Mon, 12 Oct 2015 07:42:42 -0600 [thread overview]
Message-ID: <561BB8D2.60402@redhat.com> (raw)
In-Reply-To: <1444397988-20167-3-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On 10/09/2015 07:39 AM, Denis V. Lunev wrote:
> From: Andrey Smetanin <asmetanin@virtuozzo.com>
>
> A new vcpu exit is introduced to notify the userspace of the
> changes in Hyper-V synic configuraion triggered by guest writing to the
s/configuraion/configuration/
Is 'synic' intended? Is it short for something (if so, spelling it out
may help)?
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -3331,6 +3331,12 @@ the userspace IOAPIC should process the EOI and retrigger the interrupt if
> it is still asserted. Vector is the LAPIC interrupt vector for which the
> EOI was received.
>
> + /* KVM_EXIT_HYPERV */
> + struct kvm_hyperv_exit hyperv;
> +Indicates that the VCPU's exits into userspace to process some tasks
s/VCPU's/VCPU/
> +related with Hyper-V emulation. Currently used to synchronize modified
> +Hyper-V synic state with userspace.
Again, is 'synic' intended? Hmm, I see it throughout the patch, so it
looks intentional, but I keep trying to read it as a typo for 'sync'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-12 13:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 13:39 [Qemu-devel] [PATCH 0/2] Hyper-V synthetic interrupt controller Denis V. Lunev
2015-10-09 13:39 ` [Qemu-devel] [PATCH 1/2] kvm/x86: " Denis V. Lunev
2015-10-09 14:42 ` Paolo Bonzini
2015-10-09 15:53 ` Roman Kagan
2015-10-09 15:58 ` Paolo Bonzini
2015-10-12 7:54 ` Christian Borntraeger
2015-10-12 8:48 ` Cornelia Huck
2015-10-12 8:58 ` Paolo Bonzini
2015-10-12 11:05 ` Roman Kagan
2015-10-09 13:39 ` [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit Denis V. Lunev
2015-10-09 14:41 ` Paolo Bonzini
2015-10-09 14:53 ` Roman Kagan
2015-10-09 14:57 ` Paolo Bonzini
2015-10-12 13:42 ` Eric Blake [this message]
2015-10-12 13:44 ` Eric Blake
2015-10-12 13:46 ` Paolo Bonzini
2015-10-12 13:46 ` Denis V. Lunev
2015-10-12 22:21 ` KY Srinivasan
2015-10-12 13:52 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561BB8D2.60402@redhat.com \
--to=eblake@redhat.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=gleb@kernel.org \
--cc=kys@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).