From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZldYN-0003MT-HG for qemu-devel@nongnu.org; Mon, 12 Oct 2015 09:54:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZldYJ-0007oU-HW for qemu-devel@nongnu.org; Mon, 12 Oct 2015 09:54:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZldYJ-0007oP-B2 for qemu-devel@nongnu.org; Mon, 12 Oct 2015 09:54:11 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 03D7CC0C1B0D for ; Mon, 12 Oct 2015 13:54:11 +0000 (UTC) References: <1443787955-19823-1-git-send-email-kchamart@redhat.com> <560EC614.9000109@redhat.com> <20151012110441.GP21383@tesla.theccd.local> From: Eric Blake Message-ID: <561BBB82.7020707@redhat.com> Date: Mon, 12 Oct 2015 07:54:10 -0600 MIME-Version: 1.0 In-Reply-To: <20151012110441.GP21383@tesla.theccd.local> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ipWF0r3LBj1wOmVUq1AvCNTe49av0TQbI" Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy , Max Reitz Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ipWF0r3LBj1wOmVUq1AvCNTe49av0TQbI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 05:04 AM, Kashyap Chamarthy wrote: > [Sorry, I noticed your question only just now, as I was briefly away > from this list.] >=20 > On Fri, Oct 02, 2015 at 07:59:48PM +0200, Max Reitz wrote: >> On 02.10.2015 14:12, Kashyap Chamarthy wrote: >>> Although the canonical source of reference for QMP commands is >>> qapi-schema.json, for consistency's sake, update qmp-commands.hx to >>> state the list of supported transactionable operations, namely: >>> >>> actions array: >>> - - "type": the operation to perform. The only supported >>> - value is "blockdev-snapshot-sync". (json-string) >>> + - "type": the operation to perform (json-string). Possible >>> + values: "drive-backup", "blockdev-backup", >>> + "blockdev-snapshot-sync", >>> + "blockdev-snapshot-internal-sync", >>> + "abort", "block-dirty-bitmap-add", >>> + "block-dirty-bitmap-clear" >>> - "data": a dictionary. The contents depend on the value >>> of "type". When "type" is "blockdev-snapshot-sync": >>> - "device": device name to snapshot (json-string) >>> >> >> Do you want to extend this list, too? Right now it only contains >> parameter information for blockdev-snapshot-sync and >> blockdev-snapshot-internal-sync. >=20 > You mean, all the parameters for rest of the transactionable commands > that one can possibly add (taking block-core.json)? Or conversely, we could drop the action-specific arguments, and just say something like "see the documentation for specific additional fields appropriate for that action" > If so, I can do try that if that's the preferred way, but maybe it can > be done as a separate commit, since it's been that way for a while? =20 Yes, at this point, a separate commit for any further cleanups is fine. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ipWF0r3LBj1wOmVUq1AvCNTe49av0TQbI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG7uCAAoJEKeha0olJ0NqikcIAK6N+DP4jEZvWNlCNnSe2GhF nWn7j5RxPCAV1HHm2g3w29Ak+9ArKtJPH1Hgw7Twe1nDW9t/e5bJcwHASFSc/qB1 LlxMYWL/z0jjXora8thCDW/VfyEGG2Xl+OHv2AGhlzJxx9Mk2Ml3+c1AiAqk7NsD Tt8/hOoFyZ0AH8tiRdSIfIxhJ1DMMnWDmWHYQstlG1nDGAix55U2JhrQpGubWPE2 vTJJs4uj5aZkWqBT552PL8Vo9ILdLHZ8gmgCe/MfqJWYgj0Ne8VsZ5j9ce4EjAgM tv2nKK9DMm5Fgbf8iPhZ/E4mL/Bl5fNjwSHkymHllawsI+kumxntP7QUvbrqyu4= =PO/V -----END PGP SIGNATURE----- --ipWF0r3LBj1wOmVUq1AvCNTe49av0TQbI--