From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlddf-0008Br-2k for qemu-devel@nongnu.org; Mon, 12 Oct 2015 09:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlddb-0000sJ-04 for qemu-devel@nongnu.org; Mon, 12 Oct 2015 09:59:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zldda-0000sE-OK for qemu-devel@nongnu.org; Mon, 12 Oct 2015 09:59:38 -0400 References: <1444403661-29161-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <561BBCC9.20305@redhat.com> Date: Mon, 12 Oct 2015 07:59:37 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MRqKKoCv1H6wis6JlQBgtluEPXOiwvVaX" Subject: Re: [Qemu-devel] [PULL 00/20] QAPI patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Markus Armbruster Cc: QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MRqKKoCv1H6wis6JlQBgtluEPXOiwvVaX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 07:25 AM, Peter Maydell wrote: > On 9 October 2015 at 16:14, Markus Armbruster wrote= : >> The following changes since commit b37686f7e84b22cfaf7fd01ac5133f2617c= c3027: >> >> Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-req= uest' into staging (2015-10-09 12:18:14 +0100) >> >> are available in the git repository at: >> >> git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-10-09 >> >> for you to fetch changes up to 51c605bab50f1b9e0766aa9ed14c1abe58eb7f4= 8: >> >> qapi: Simplify gen_visit_fields() error handling (2015-10-09 16:44:1= 0 +0200) >> >> ---------------------------------------------------------------- >> QAPI patches >> >> ---------------------------------------------------------------- >=20 > Hi. I see a clang compile failure due to this warning (OSX and Linux): >=20 > /Users/pm215/src/qemu-for-merges/tests/test-qmp-input-visitor.c:500:33:= > warning: implicit conversion from 'double' to 'gint64' (aka 'long') > changes value from 42.5 to 42 [-Wliteral-conversion] >=20 Copy-and-paste strikes me again :( Markus, you could squash this into "qapi: Test use of 'number' within alternates" for the obvious fix (line numbers may be off). diff --git i/tests/test-qmp-input-visitor.c w/tests/test-qmp-input-visito= r.c index 5f4f45b..57617ac 100644 --- i/tests/test-qmp-input-visitor.c +++ w/tests/test-qmp-input-visitor.c @@ -409,7 +409,7 @@ static void test_visitor_in_alternate_number(TestInputVisitorData *data, v =3D visitor_input_test_init(data, "42.5"); visit_type_AltNumInt(v, &ani, NULL, &error_abort); g_assert_cmpint(ani->type, =3D=3D, QTYPE_QFLOAT); - g_assert_cmpint(ani->n, =3D=3D, 42.5); + g_assert_cmpfloat(ani->n, =3D=3D, 42.5); qapi_free_AltNumInt(ani); } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MRqKKoCv1H6wis6JlQBgtluEPXOiwvVaX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG7zJAAoJEKeha0olJ0NqEVAH/j5CEgjQElh/GmGYtS5j0Js+ 2frdqUjvY42XtV4DVNZfgIrP+qIRAJtmDtYzv6752Ddw+M4IXMaZo+2RKu18fdx0 7bWApL4rz08m2e5KHtZhrnejxzaOrPJZnqCJn+eM7EU0TneOeFJf7TWzJvUVCsAi GiCdMXZZFUspYwXQgzaa8FNOPHO4pjCpUeAnAfYfhZV/NRFFDzSQBhgCsPt3/AOg UkXrsO2LyycFrgQE2wLLJHt9/5HAYcmQ0oCrxFQF/oKAxVG4is5XaKm5/M1jvXSX KCkrgzIUNseyq+Gd3O42k8AaxuTmOlDccubulGjFGPQx7Ph+kgl5PVp8SgSvGC8= =O1SN -----END PGP SIGNATURE----- --MRqKKoCv1H6wis6JlQBgtluEPXOiwvVaX--