From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZleY6-00046r-Sb for qemu-devel@nongnu.org; Mon, 12 Oct 2015 10:58:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZleY1-0006ab-Uc for qemu-devel@nongnu.org; Mon, 12 Oct 2015 10:58:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZleY1-0006aL-Px for qemu-devel@nongnu.org; Mon, 12 Oct 2015 10:57:57 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 5CA2D4AD5F for ; Mon, 12 Oct 2015 14:57:57 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-3-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <561BCA74.7040200@redhat.com> Date: Mon, 12 Oct 2015 08:57:56 -0600 MIME-Version: 1.0 In-Reply-To: <1444637004-20195-3-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XVmgihueo71PX6qviOpCXXXRiaHuSHqGj" Subject: Re: [Qemu-devel] [PATCH 02/21] qemu-char: cleanup HAVE_CHARDEV_* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XVmgihueo71PX6qviOpCXXXRiaHuSHqGj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 02:03 AM, Paolo Bonzini wrote: > Move the #ifdef up into qmp_chardev_add, and avoid duplicating > the code that reports unavailable backends. Split HAVE_CHARDEV_TTY > into HAVE_CHARDEV_SERIAL and HAVE_CHARDEV_PTY. >=20 > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/qemu-char.c b/qemu-char.c > index f51c0aa..7219d56 100644 > --- a/qemu-char.c Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XVmgihueo71PX6qviOpCXXXRiaHuSHqGj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG8p0AAoJEKeha0olJ0NqO3QH+QGptGafjOf2J5VZdVbYhNxI JvLkiQ4a50MrHLEu1V9Cbrt3AsTXjFrO5Mzm23QpKXUHCktgLTB5VnVUgo5Kv4Zx lff4RQHIQhymOU8J+UL8J09e5dyWTdQhDnHAVQgilskLwOm75zdBP7coK9V5oOpj iHdkWWaHGJRGOMp7YDd6lVhSN5/GnZ4suNxgO3Lu2Ui5DGuaWz1rH9DwUBeCh9nG ODnerGzRHND2HsnMPmxdJo9NtSojQ6LDeLy3hG76F00h5bhdieABuHxq1jRdcAKv iNqKJxAMR/pbFZOS8wokLffqfpg8iZg7oIto6yoTxfCFuIAHj+0qaCuzAJjBin0= =4cmb -----END PGP SIGNATURE----- --XVmgihueo71PX6qviOpCXXXRiaHuSHqGj--