From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlefw-0000SD-UY for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:06:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlefs-00014h-SG for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:06:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlefs-00014b-MN for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:06:04 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 4FEFFC0C1B1B for ; Mon, 12 Oct 2015 15:06:04 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-5-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <561BCC5B.1010404@redhat.com> Date: Mon, 12 Oct 2015 09:06:03 -0600 MIME-Version: 1.0 In-Reply-To: <1444637004-20195-5-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fQPIw2K5OjvRWnN2ISrBUaDCUawQG7JCO" Subject: Re: [Qemu-devel] [PATCH 04/21] qemu-char: convert file backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fQPIw2K5OjvRWnN2ISrBUaDCUawQG7JCO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 02:03 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) >=20 > @@ -4242,7 +4250,7 @@ ChardevReturn *qmp_chardev_add(const char *id, Ch= ardevBackend *backend, > if (chr =3D=3D NULL) { > switch (backend->kind) { > case CHARDEV_BACKEND_KIND_FILE: > - chr =3D qmp_chardev_open_file(backend->file, &local_err); > + abort(); > break; The break is now dead code. > #ifdef HAVE_CHARDEV_SERIAL > case CHARDEV_BACKEND_KIND_SERIAL: > @@ -4380,7 +4388,7 @@ static void register_types(void) > register_char_driver("ringbuf", CHARDEV_BACKEND_KIND_RINGBUF, > qemu_chr_parse_ringbuf, NULL); > register_char_driver("file", CHARDEV_BACKEND_KIND_FILE, > - qemu_chr_parse_file_out, NULL); > + qemu_chr_parse_file_out, qmp_chardev_open_fil= e); Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fQPIw2K5OjvRWnN2ISrBUaDCUawQG7JCO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG8xbAAoJEKeha0olJ0NqkpYH/iDLBe+IK079SSBxJpThCVfv 8qdOm2PfSXQiIZuYxStv2ZNjouh7cwA20ZD6duURoaE9ubN1Qrecdo5tb7ADBIrK 3WpwQHBw3EHKJm+bIykZXkqIDhDniObCrc3B6dbbmfBioTGvGzGO0/ExcTcngoxn p5g79EhLq/2fy6njpTD0H9vMDO4EGKfFJYP2XrQZrwmufEOhBZ+Zp4/T6V4+Lx3u ebJI8lSUUoRmEISnoOJzdYK1VQ2UemrgQkFZs5fISzMjQtbdLfAdqYEuAPO8f40/ fed/rkO/ha7iyX8WQVdCfPBjxQGgAHN2BcV9pU5R1ZE+vK87bbUW/0p/NghAS+w= =5DIg -----END PGP SIGNATURE----- --fQPIw2K5OjvRWnN2ISrBUaDCUawQG7JCO--