From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlejT-00039d-Hg for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlejP-000223-FD for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:09:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlejP-00021y-AO for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:09:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id E38424AD5F for ; Mon, 12 Oct 2015 15:09:42 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-6-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <561BCD36.4070406@redhat.com> Date: Mon, 12 Oct 2015 09:09:42 -0600 MIME-Version: 1.0 In-Reply-To: <1444637004-20195-6-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cdTXaOXL88BFr2VdR0JG8Usq95EkgH5uu" Subject: Re: [Qemu-devel] [PATCH 05/21] qemu-char: convert serial backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cdTXaOXL88BFr2VdR0JG8Usq95EkgH5uu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 02:03 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 48 +++++++++++++++++++++++++++++------------------- > 1 file changed, 29 insertions(+), 19 deletions(-) >=20 > @@ -4252,11 +4262,9 @@ ChardevReturn *qmp_chardev_add(const char *id, C= hardevBackend *backend, > case CHARDEV_BACKEND_KIND_FILE: > abort(); > break; > -#ifdef HAVE_CHARDEV_SERIAL > case CHARDEV_BACKEND_KIND_SERIAL: > - chr =3D qmp_chardev_open_serial(backend->serial, &local_er= r); > + abort(); > break; > -#endif Another dead break after abort(). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cdTXaOXL88BFr2VdR0JG8Usq95EkgH5uu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG802AAoJEKeha0olJ0NqmZcH/2skXuWXc0Ziw4UhqehPEjSL 4Om7Ec9v3bALY0W+D0nKhjBI/cfeIdyEBTC/2F+qwtRlGn+IzFcbdLa1Q0b2Mnjn gAO5q0M1SGa+gGkbDidY1FcxJnT5VD5oyTL0kZNDw0Ei8f6u6O7PPXZ0wWAaJOmx l/T9rS92s4KWMFHkUShHiZ+RLxDlZc2ZtkKZxZH+YwEDsij24v7ISfhCKjuBkczC tLdsPhrBkUxUShlRJkP4XrALIyCG+BUiu2+5tVTy/cgMMG1ZDxeHsFoy6Nx50k03 +YtC+Nr4G2OH29LdKIsuJYgYVA0N9fVzvrfgauHx2OPaZhx9SB4IzKs/PtRfmw0= =CTzk -----END PGP SIGNATURE----- --cdTXaOXL88BFr2VdR0JG8Usq95EkgH5uu--