Re: [Qemu-devel] [PATCH 04/21] qemu-char: convert file backend to data-driven creation

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 04/21] qemu-char: convert file backend to data-driven creation
Date: Mon, 12 Oct 2015 17:17:22 +0200	[thread overview]
Message-ID: <561BCF02.2010107@redhat.com> (raw)
In-Reply-To: <561BCC5B.1010404@redhat.com>



On 12/10/2015 17:06, Eric Blake wrote:
>> >          case CHARDEV_BACKEND_KIND_FILE:
>> > -            chr = qmp_chardev_open_file(backend->file, &local_err);
>> > +            abort();
>> >              break;
> The break is now dead code.
> 

They all go away in patch 21. :)

Paolo

next prev parent reply	other threads:[~2015-10-12 15:17 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12  8:03 [Qemu-devel] [PATCH 00/22] qemu-char: refactoring of chardev creation Paolo Bonzini
2015-10-12  8:03 ` [Qemu-devel] [PATCH 01/21] qemu-char: cleanup qmp_chardev_add Paolo Bonzini
2015-10-12 14:55   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 02/21] qemu-char: cleanup HAVE_CHARDEV_* Paolo Bonzini
2015-10-12 14:57   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 03/21] qemu-char: add create to register_char_driver Paolo Bonzini
2015-10-12 15:04   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 04/21] qemu-char: convert file backend to data-driven creation Paolo Bonzini
2015-10-12 15:06   ` Eric Blake
2015-10-12 15:17     ` Paolo Bonzini [this message]
2015-10-12  8:03 ` [Qemu-devel] [PATCH 05/21] qemu-char: convert serial " Paolo Bonzini
2015-10-12 15:09   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 06/21] qemu-char: convert parallel " Paolo Bonzini
2015-10-12 15:13   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 07/21] qemu-char: convert pipe " Paolo Bonzini
2015-10-12 15:16   ` Eric Blake
2015-10-12 15:18     ` Paolo Bonzini
2015-10-12 15:21       ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 08/21] qemu-char: convert socket " Paolo Bonzini
2015-10-12 15:20   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 09/21] qemu-char: convert UDP " Paolo Bonzini
2015-10-12 15:22   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 10/21] qemu-char: convert pty " Paolo Bonzini
2015-10-12 15:22   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 11/21] qemu-char: convert null " Paolo Bonzini
2015-10-12 15:23   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 12/21] qemu-char: convert mux " Paolo Bonzini
2015-10-12 15:24   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 13/21] qemu-char: convert msmouse " Paolo Bonzini
2015-10-12 15:25   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 14/21] qemu-char: convert braille " Paolo Bonzini
2015-10-12 15:30   ` Eric Blake
2015-10-12 15:41     ` Samuel Thibault
2015-10-14 15:51       ` Paolo Bonzini
2015-10-14 15:55         ` Eric Blake
2015-10-14 16:34         ` Samuel Thibault
2015-10-14 16:51           ` Paolo Bonzini
2015-10-12  8:03 ` [Qemu-devel] [PATCH 15/21] qemu-char: convert testdev " Paolo Bonzini
2015-10-12 15:49   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 16/21] qemu-char: convert stdio " Paolo Bonzini
2015-10-12 15:50   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 17/21] qemu-char: convert console " Paolo Bonzini
2015-10-12 15:50   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 18/21] qemu-char: convert spice " Paolo Bonzini
2015-10-12 15:51   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 19/21] qemu-char: convert vc " Paolo Bonzini
2015-10-12 15:53   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 20/21] qemu-char: convert ringbuf " Paolo Bonzini
2015-10-12 15:53   ` Eric Blake
2015-10-12  8:03 ` [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conversion to cd->create Paolo Bonzini
2015-10-12 15:55   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561BCF02.2010107@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).