From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zler0-0002mu-4b for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:17:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlequ-0004yi-1A for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:17:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zleqt-0004yc-SB for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:17:27 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 712828F263 for ; Mon, 12 Oct 2015 15:17:27 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-5-git-send-email-pbonzini@redhat.com> <561BCC5B.1010404@redhat.com> From: Paolo Bonzini Message-ID: <561BCF02.2010107@redhat.com> Date: Mon, 12 Oct 2015 17:17:22 +0200 MIME-Version: 1.0 In-Reply-To: <561BCC5B.1010404@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/21] qemu-char: convert file backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: armbru@redhat.com On 12/10/2015 17:06, Eric Blake wrote: >> > case CHARDEV_BACKEND_KIND_FILE: >> > - chr = qmp_chardev_open_file(backend->file, &local_err); >> > + abort(); >> > break; > The break is now dead code. > They all go away in patch 21. :) Paolo