From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlev3-0007Up-EP for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:21:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlev0-0006Ym-79 for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:21:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlev0-0006Yb-2M for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:21:42 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id A5471A443E for ; Mon, 12 Oct 2015 15:21:41 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-8-git-send-email-pbonzini@redhat.com> <561BCED5.5010303@redhat.com> <561BCF58.8090503@redhat.com> From: Eric Blake Message-ID: <561BD004.3030708@redhat.com> Date: Mon, 12 Oct 2015 09:21:40 -0600 MIME-Version: 1.0 In-Reply-To: <561BCF58.8090503@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6FROQV4Xq4bS62gagA5BwkvEdfq6T4QsU" Subject: Re: [Qemu-devel] [PATCH 07/21] qemu-char: convert pipe backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6FROQV4Xq4bS62gagA5BwkvEdfq6T4QsU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 09:18 AM, Paolo Bonzini wrote: >=20 >=20 > On 12/10/2015 17:16, Eric Blake wrote: >>> rp) >>>> { >>>> + ChardevHostdev *opts =3D backend->pipe; >>>> int fd_in, fd_out; >>>> char filename_in[CHR_MAX_FILENAME_SIZE]; >>>> char filename_out[CHR_MAX_FILENAME_SIZE]; >>>> const char *filename =3D opts->device; >>>> =20 >>>> - if (filename =3D=3D NULL) { >>>> - fprintf(stderr, "chardev: pipe: no filename given\n"); >>>> - return NULL; >>>> - } >>>> - >>>> snprintf(filename_in, CHR_MAX_FILENAME_SIZE, "%s.in", filename)= ; >> Do we need assert(filename) here? >> >> >=20 > No, "device" is not optional in the definition of ChardevHostdev. Okay, then with the \n gone, Reviewed-by: Eric Blake (and I'll quit complaining about dead break) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6FROQV4Xq4bS62gagA5BwkvEdfq6T4QsU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG9AEAAoJEKeha0olJ0NqpC8H/0QGVS8rMDti2mwPYChRladb 69Uk0323/L0ezBqHFAZgfkG73qCfPeiimKipAvHZI8Dj7mJ33CvAb8dw1iS+X8tc srQpcj0qUqcwxiLsphYBy6MJeZMQcHp0RW0vXF9HPika471gmN9ui8qVR0ZdBCP1 5Hf1lGwokTfYW9MKACQz9omRr69kXiHJyKLs7vMz4ARoW2zBRQHTN0cXiFNdNiRi Ayj4u3tamolGE9CGaTTWs7N8BrpXQ8FZZRDrAuz3+pj7QIP3+VJcNAYQ20QOM213 D0HvKaK8isGl0xZ7HnpBrS7VnamULpBBH9Vqm2RXEeKD3c6E57FkNbrdc642AUw= =ZvcZ -----END PGP SIGNATURE----- --6FROQV4Xq4bS62gagA5BwkvEdfq6T4QsU--