From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlf3J-0005pl-MZ for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:30:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlf3G-0001Rl-C3 for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:30:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlf3G-0001RG-6t for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:30:14 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 8FF5633A8B4 for ; Mon, 12 Oct 2015 15:30:13 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-15-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <561BD204.7050307@redhat.com> Date: Mon, 12 Oct 2015 09:30:12 -0600 MIME-Version: 1.0 In-Reply-To: <1444637004-20195-15-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6k17qFINED9H8jkwIiol6m5Gv7ip7I8La" Subject: Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6k17qFINED9H8jkwIiol6m5Gv7ip7I8La Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 02:03 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > backends/baum.c | 13 ++++++++----- > include/sysemu/char.h | 3 --- > qemu-char.c | 4 +--- > stubs/Makefile.objs | 1 - > stubs/chr-baum-init.c | 7 ------- > 5 files changed, 9 insertions(+), 19 deletions(-) > delete mode 100644 stubs/chr-baum-init.c >=20 > @@ -586,14 +589,14 @@ CharDriverState *chr_baum_init(void) > =20 > baum->brlapi_fd =3D brlapi__openConnection(handle, NULL, NULL); > if (baum->brlapi_fd =3D=3D -1) { > - brlapi_perror("baum_init: brlapi_openConnection"); > + error_setg(errp, "baum_init: brlapi_openConnection"); error_setg() already tracks function name, so you could drop 'baum_init: '. Also, I assume that brlapi_perror() adds additional information to the error message it prints, such as conversion of a brlapi-specific error message in the same manner in which perror() converts errno and in which error_setg_errno() would be used. So I don't know if this conversion is the best. But I'm unfamiliar with brlapi_* in general, to know if there is anything better to use, so I'd rather get a second opinion on this. ' Other than the possibility of the incorrect conversion of (several) error messages, the rest of the patch looks fine to me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6k17qFINED9H8jkwIiol6m5Gv7ip7I8La Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEbBAEBCAAGBQJWG9IEAAoJEKeha0olJ0NqzQYH9jNGXjuKYebhHSmP9OIPHqK0 1XYATHZ+haJHcN/bsQGPiLcOBgDPu8RjPg/19iQVVY8ZcaLwwGI7k0oRiRvVAYd5 xYoOc81tbJabeDAl7enGhvMCBJ748+hYDQqkNWTPY0R2Qu6tbDNbR+aKkblrgOSz KB7DVM7dbozY5JTtqH3RBgLdTzvI+eS7YyuG+qLpLzpjKa99nB/T6e2c5kCTqgYU WYs6jK2C3c7HkHmV3sMJvxHjFm0umCOBdjqRX8QbXgYhy69jhcB6byF1nvMXwaWT GtJGjnOAiIWoAuiPZNCEDWglqK6vDoV2WYMFWm9mwIoay8ikJq3TmOTAkHPqrw== =BwDX -----END PGP SIGNATURE----- --6k17qFINED9H8jkwIiol6m5Gv7ip7I8La--