From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlfMz-0006IJ-5C for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:50:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlfMu-0007ZI-W1 for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:50:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlfMu-0007Z0-Qr for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:50:32 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7E63A96C3 for ; Mon, 12 Oct 2015 15:50:32 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-17-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <561BD6C7.7090906@redhat.com> Date: Mon, 12 Oct 2015 09:50:31 -0600 MIME-Version: 1.0 In-Reply-To: <1444637004-20195-17-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hTGXA9VTALlvWKkGncJ8UCSJXJENCBbqc" Subject: Re: [Qemu-devel] [PATCH 16/21] qemu-char: convert stdio backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hTGXA9VTALlvWKkGncJ8UCSJXJENCBbqc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 02:03 AM, Paolo Bonzini wrote: > The backend now always returns errors via the Error* argument. > This avoids a double error message. Before: >=20 > qemu-system-x86_64: -chardev stdio,id=3Dbase: cannot use stdio with= -daemonize > qemu-system-x86_64: -chardev stdio,id=3Dbase: Failed to create char= dev >=20 > After: >=20 > qemu-system-x86_64: -chardev stdio,id=3Dbase: cannot use stdio with= -daemonize >=20 > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 57 +++++++++++++++++++++++++++++++++++++++--------------= ---- > 1 file changed, 39 insertions(+), 18 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hTGXA9VTALlvWKkGncJ8UCSJXJENCBbqc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG9bHAAoJEKeha0olJ0NqQM4H/iLBV73BSBOzFE8/MviHJzjO hvDNXIuPLEejeXKMis4PdkwbK/ul6VKfqMlWTectP9JP4uxLMr368Qv3kSgGDGIa vlUSWEnUaZBilqpDLi9N0DkZZfp6UYgn3IpkVfFZ+vgnXDcLW6fW5DJ2D3wqUDyS kws6G7aWxvicVvti3q2Z/AnrAPh9ZVnsks7zWebVSem5Miuy4UVhi9gLXKeRCrjG 1DciqoLyfj/9AT8VP5E1cc5c5TmG5C0WlJNFfKnipSRlmAlZOc4Ih0BfhYcQDWhz vcJiPGmA2vSmqQT3GNsCgoeUmLUCIEuHzrVp0/5RFYcayVEIRXzpbM0sj2meGJ8= =grcJ -----END PGP SIGNATURE----- --hTGXA9VTALlvWKkGncJ8UCSJXJENCBbqc--