From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlfRN-0003RM-Ot for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:55:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlfRH-0000vJ-Hl for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:55:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlfRH-0000uz-CC for qemu-devel@nongnu.org; Mon, 12 Oct 2015 11:55:03 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 092D9A0E4A for ; Mon, 12 Oct 2015 15:55:03 +0000 (UTC) References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-22-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <561BD7D6.3070205@redhat.com> Date: Mon, 12 Oct 2015 09:55:02 -0600 MIME-Version: 1.0 In-Reply-To: <1444637004-20195-22-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kn5RcS9e8UKI59qMUiFEvbVXLWnAFRcFg" Subject: Re: [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conversion to cd->create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kn5RcS9e8UKI59qMUiFEvbVXLWnAFRcFg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2015 02:03 AM, Paolo Bonzini wrote: > All backends now return errors through Error*, so the "Failed to > create chardev" placeholder error can only be reached if the backend > is not available (and only from the chardev-add QMP command; instead, > the -chardev command line option fails earlier). >=20 > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 80 ++++-------------------------------------------------= -------- > 1 file changed, 4 insertions(+), 76 deletions(-) >=20 Nice diffstat ratio! Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kn5RcS9e8UKI59qMUiFEvbVXLWnAFRcFg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG9fWAAoJEKeha0olJ0NqCfIH+wXhpbjIXFIXvea/GLwRvVMY syXED2Q+t9a9eowz1nFbJAXNLYkwh8KM8SUyY+uaj3UEfnbQ92wJ/zAS9wQGzBZ6 Vy7FdLin96MQXuTlRuhK/vkpFToqQzsjom52leFPm62XBnldQobAoJV7IN44jMd+ 4INLz6+nDmjWqIbWGRbhzHNOFSPq45p99uVNch62KH96QiDsbRtkLTnWtQb19H5x C+hPBIpBfuFrMHklxVo9jFmqPfxlEX2q3aHpwtwi42V4b12Tq2O6tQYNwa5f5By4 Kv3bcLgdu0BiOT9HbMX9kKYWOhBEYWHw86siQUUt5k+y5UMMyxGZqjPF2S7EmF4= =B0EM -----END PGP SIGNATURE----- --kn5RcS9e8UKI59qMUiFEvbVXLWnAFRcFg--