From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgCo-0000Nt-OM for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:44:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlgCl-0001Oq-IR for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:44:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgCl-0001Ok-Bc for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:44:07 -0400 References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-15-git-send-email-guangrong.xiao@linux.intel.com> From: Eric Blake Message-ID: <561BE34E.7030901@redhat.com> Date: Mon, 12 Oct 2015 10:43:58 -0600 MIME-Version: 1.0 In-Reply-To: <1444535584-18220-15-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="soOP0ICaexi7Fob3Q6AmHJ7rmjP7GG6Pg" Subject: Re: [Qemu-devel] [PATCH v3 14/32] pc-dimm: drop the prefix of pc-dimm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong , pbonzini@redhat.com, imammedo@redhat.com Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --soOP0ICaexi7Fob3Q6AmHJ7rmjP7GG6Pg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/10/2015 09:52 PM, Xiao Guangrong wrote: > This patch is generated by this script: >=20 > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type = f \ > | xargs sed -i "s/PC_DIMM/DIMM/g" >=20 > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type = f \ > | xargs sed -i "s/PCDIMM/DIMM/g" >=20 > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type = f \ > | xargs sed -i "s/pc_dimm/dimm/g" >=20 > find ./ -name "trace-events" -type f | xargs sed -i "s/pc-dimm/dimm/g" >=20 > It prepares the work which abstracts dimm device type for both pc-dimm = and > nvdimm >=20 > Signed-off-by: Xiao Guangrong > --- > hmp.c | 2 +- > +++ b/qapi-schema.json > @@ -3684,9 +3684,9 @@ > { 'command': 'query-memdev', 'returns': ['Memdev'] } > =20 > ## > -# @PCDIMMDeviceInfo: > +# @DIMMDeviceInfo: > # > -# PCDIMMDevice state information > +# DIMMDevice state information > # > # @id: #optional device's ID > # > @@ -3706,7 +3706,7 @@ > # > # Since: 2.1 > ## > -{ 'struct': 'PCDIMMDeviceInfo', > +{ 'struct': 'DIMMDeviceInfo', > 'data': { '*id': 'str', > 'addr': 'int', > 'size': 'int', > @@ -3725,7 +3725,7 @@ > # > # Since: 2.1 > ## > -{ 'union': 'MemoryDeviceInfo', 'data': {'dimm': 'PCDIMMDeviceInfo'} } > +{ 'union': 'MemoryDeviceInfo', 'data': {'dimm': 'DIMMDeviceInfo'} } Struct names are not ABI, so this change is safe. I have not reviewed the rest of the patch, but I don't see any problems from the qapi perspective. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --soOP0ICaexi7Fob3Q6AmHJ7rmjP7GG6Pg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWG+NOAAoJEKeha0olJ0Nq9o4H/1ykpNMUdjKILJY7RI4ELpX3 cDZEGjQphJB5qp9z8DCKjKjKMtWoZidBVmnrO/RCskTTKgoBzeG+BG9iWyCQI7QZ qC8K5TuA5b8dqMZ4qlYl9D1RoR/WUA1Nmf1H88VNMpFRzTUlFZqENzCE5iVPn3bY m5i3o5fAWxyyk0869sjNkGLrT99WfnmLtmG0CisMkEm9nKYlj98TgeneZfVur8nG 9rXCtU629xNpW/zlwe+jAAHxg93++yY8AyAj/AUJXrzNA5Uy8iHQbfvynCULrIZl aYt8eJRNtgE48odWitKDnmpjv2bBHCWiRj4v9opHk2Ht8WbcdxNRViR41hzUdzo= =OQIq -----END PGP SIGNATURE----- --soOP0ICaexi7Fob3Q6AmHJ7rmjP7GG6Pg--