Re: [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest

["Andreas Färber" <afaerber@suse.de>]

Am 12.10.2015 um 18:40 schrieb marcandre.lureau@redhat.com:
> From: Andreas Färber <afaerber@suse.de>
> 
> Note that it launches two instances, as sharing memory is the purpose of
> ivshmem.
> 
> Cc: Cam Macdonell <cam@cs.ualberta.ca>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> [ Remove Nahanni codename, add test to pci set - Marc-André ]
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/Makefile       |  3 +++
>  tests/ivshmem-test.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 54 insertions(+)
>  create mode 100644 tests/ivshmem-test.c
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index dbd32a6..c44b8de 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -149,6 +149,8 @@ gcov-files-pci-y += hw/display/virtio-gpu-pci.c
>  gcov-files-pci-$(CONFIG_VIRTIO_VGA) += hw/display/virtio-vga.c
>  check-qtest-pci-y += tests/intel-hda-test$(EXESUF)
>  gcov-files-pci-y += hw/audio/intel-hda.c hw/audio/hda-codec.c
> +check-qtest-pci-$(CONFIG_IVSHMEM) += tests/ivshmem-test$(EXESUF)
> +gcov-files-pci-y += hw/misc/ivshmem.c

Based on my comment from Saturday, this line is probably wrong... but
doesn't need to hold up this queue.

My patch adding it to i386 variable had used i386-softmmu/hw/... path.
We then have this for x86_64:

gcov-files-x86_64-y = $(subst
i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))

gcov-files-pci-y is currently only added to i386, so the prefix could
just be added back, whereas when we do pci tests also for ppc, arm, etc.
we'll have to copy that subst around or think of a better solution.

Marc-André, can you prepare a follow-up fix for ivshmem-test please?

Regards,
Andreas

>  
>  check-qtest-i386-y = tests/endianness-test$(EXESUF)
>  check-qtest-i386-y += tests/fdc-test$(EXESUF)
[snip]

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)