From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlhOV-0006Jn-TN for qemu-devel@nongnu.org; Mon, 12 Oct 2015 14:00:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlhOP-0004JC-Vy for qemu-devel@nongnu.org; Mon, 12 Oct 2015 14:00:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:56779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlhOP-0004Il-Ql for qemu-devel@nongnu.org; Mon, 12 Oct 2015 14:00:13 -0400 References: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> <1444668104-22955-2-git-send-email-marcandre.lureau@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <561BF52A.6080804@suse.de> Date: Mon, 12 Oct 2015 20:00:10 +0200 MIME-Version: 1.0 In-Reply-To: <1444668104-22955-2-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, pbonzini@redhat.com, cam@cs.ualberta.ca Am 12.10.2015 um 18:40 schrieb marcandre.lureau@redhat.com: > From: Andreas F=C3=A4rber >=20 > Note that it launches two instances, as sharing memory is the purpose o= f > ivshmem. >=20 > Cc: Cam Macdonell > Cc: Marc-Andr=C3=A9 Lureau > Signed-off-by: Andreas F=C3=A4rber > [ Remove Nahanni codename, add test to pci set - Marc-Andr=C3=A9 ] > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > tests/Makefile | 3 +++ > tests/ivshmem-test.c | 51 ++++++++++++++++++++++++++++++++++++++++++++= +++++++ > 2 files changed, 54 insertions(+) > create mode 100644 tests/ivshmem-test.c >=20 > diff --git a/tests/Makefile b/tests/Makefile > index dbd32a6..c44b8de 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -149,6 +149,8 @@ gcov-files-pci-y +=3D hw/display/virtio-gpu-pci.c > gcov-files-pci-$(CONFIG_VIRTIO_VGA) +=3D hw/display/virtio-vga.c > check-qtest-pci-y +=3D tests/intel-hda-test$(EXESUF) > gcov-files-pci-y +=3D hw/audio/intel-hda.c hw/audio/hda-codec.c > +check-qtest-pci-$(CONFIG_IVSHMEM) +=3D tests/ivshmem-test$(EXESUF) > +gcov-files-pci-y +=3D hw/misc/ivshmem.c Based on my comment from Saturday, this line is probably wrong... but doesn't need to hold up this queue. My patch adding it to i386 variable had used i386-softmmu/hw/... path. We then have this for x86_64: gcov-files-x86_64-y =3D $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y)) gcov-files-pci-y is currently only added to i386, so the prefix could just be added back, whereas when we do pci tests also for ppc, arm, etc. we'll have to copy that subst around or think of a better solution. Marc-Andr=C3=A9, can you prepare a follow-up fix for ivshmem-test please? Regards, Andreas > =20 > check-qtest-i386-y =3D tests/endianness-test$(EXESUF) > check-qtest-i386-y +=3D tests/fdc-test$(EXESUF) [snip] --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N= =C3=BCrnberg)