From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlqQS-0003gN-LH for qemu-devel@nongnu.org; Mon, 12 Oct 2015 23:38:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlqQP-00005G-Fs for qemu-devel@nongnu.org; Mon, 12 Oct 2015 23:38:56 -0400 Received: from mga03.intel.com ([134.134.136.65]:30226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlqQP-00004z-AG for qemu-devel@nongnu.org; Mon, 12 Oct 2015 23:38:53 -0400 References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-15-git-send-email-guangrong.xiao@linux.intel.com> <561BE34E.7030901@redhat.com> From: Xiao Guangrong Message-ID: <561C7B44.3050306@linux.intel.com> Date: Tue, 13 Oct 2015 11:32:20 +0800 MIME-Version: 1.0 In-Reply-To: <561BE34E.7030901@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 14/32] pc-dimm: drop the prefix of pc-dimm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , pbonzini@redhat.com, imammedo@redhat.com Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/13/2015 12:43 AM, Eric Blake wrote: > On 10/10/2015 09:52 PM, Xiao Guangrong wrote: >> This patch is generated by this script: >> >> find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ >> | xargs sed -i "s/PC_DIMM/DIMM/g" >> >> find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ >> | xargs sed -i "s/PCDIMM/DIMM/g" >> >> find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ >> | xargs sed -i "s/pc_dimm/dimm/g" >> >> find ./ -name "trace-events" -type f | xargs sed -i "s/pc-dimm/dimm/g" >> >> It prepares the work which abstracts dimm device type for both pc-dimm and >> nvdimm >> >> Signed-off-by: Xiao Guangrong >> --- >> hmp.c | 2 +- > >> +++ b/qapi-schema.json >> @@ -3684,9 +3684,9 @@ >> { 'command': 'query-memdev', 'returns': ['Memdev'] } >> >> ## >> -# @PCDIMMDeviceInfo: >> +# @DIMMDeviceInfo: >> # >> -# PCDIMMDevice state information >> +# DIMMDevice state information >> # >> # @id: #optional device's ID >> # >> @@ -3706,7 +3706,7 @@ >> # >> # Since: 2.1 >> ## >> -{ 'struct': 'PCDIMMDeviceInfo', >> +{ 'struct': 'DIMMDeviceInfo', >> 'data': { '*id': 'str', >> 'addr': 'int', >> 'size': 'int', >> @@ -3725,7 +3725,7 @@ >> # >> # Since: 2.1 >> ## >> -{ 'union': 'MemoryDeviceInfo', 'data': {'dimm': 'PCDIMMDeviceInfo'} } >> +{ 'union': 'MemoryDeviceInfo', 'data': {'dimm': 'DIMMDeviceInfo'} } > > Struct names are not ABI, so this change is safe. > > I have not reviewed the rest of the patch, but I don't see any problems > from the qapi perspective. Thanks for your review, Eric! :)