From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlsFn-0004qs-3u for qemu-devel@nongnu.org; Tue, 13 Oct 2015 01:36:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlsFj-0000V5-Uc for qemu-devel@nongnu.org; Tue, 13 Oct 2015 01:36:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:2692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlsFj-0000Ui-Ps for qemu-devel@nongnu.org; Tue, 13 Oct 2015 01:35:59 -0400 References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <20151012144113-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <561C96CC.40702@linux.intel.com> Date: Tue, 13 Oct 2015 13:29:48 +0800 MIME-Version: 1.0 In-Reply-To: <20151012144113-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/12/2015 07:55 PM, Michael S. Tsirkin wrote: > On Sun, Oct 11, 2015 at 11:52:32AM +0800, Xiao Guangrong wrote: >> Changelog in v3: >> There is huge change in this version, thank Igor, Stefan, Paolo, Eduardo, >> Michael for their valuable comments, the patchset finally gets better shape. > > Thanks! > This needs some changes in coding style, and more comments, to > make it easier to maintain going forward. Thanks for your review, Michael. I have learned lots of thing from your comments. > > High level comments - I didn't point out all instances, > please go over code and locate them yourself. > I focused on acpi code in this review. Okay, will do. > > - fix coding style violations, prefix eveything with nvdimm_ etc Actually i did not pay attention on naming the stuff which is only internally used. Thank you for pointing it out and will fix it in next version. > - in apci code, avoid manual memory management/complex pointer math I am not very good at ACPI ASL/AML, could you please more detail? > - comments are needed to document apis & explain what's going on > - constants need comments too, refer to text that > can be looked up in acpi spec verbatim Indeed, will document carefully.