From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zly4I-0001YR-2o for qemu-devel@nongnu.org; Tue, 13 Oct 2015 07:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zly4C-0004fS-Ur for qemu-devel@nongnu.org; Tue, 13 Oct 2015 07:48:34 -0400 Received: from [59.151.112.132] (port=28828 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zly4C-0004es-IO for qemu-devel@nongnu.org; Tue, 13 Oct 2015 07:48:28 -0400 References: <1444725695-27517-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20151013114852-mutt-send-email-mst@redhat.com> From: Cao jin Message-ID: <561CF0DF.80506@cn.fujitsu.com> Date: Tue, 13 Oct 2015 19:54:07 +0800 MIME-Version: 1.0 In-Reply-To: <20151013114852-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/2] PCI-e device multi-function hot-add support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: pbonzini@redhat.com, alex.williamson@redhat.com, qemu-devel@nongnu.org, izumi.taku@jp.fujitsu.com On 10/13/2015 04:49 PM, Michael S. Tsirkin wrote: > On Tue, Oct 13, 2015 at 04:41:33PM +0800, Cao jin wrote: >> Support PCI-e device hot-add multi-function via device_add, just ensure >> add the function 0 is added last. While allow user to roll back in the >> middle via device_del, in case user regret. > > This patch doesn't seem to account of AIR though. > Yes, but the AIR function seems never be used(nobody calls the function pcie_ari_init()), so I am a little confused about should it be consindered? >> changelog: >> 1. Flag device as unexposed when func 0 doesn`t exist, via return 0xFF >> in case of gratuitous pci bus scan. >> 2. Since device is unexposed to guest, can remove function individually, >> without interaction with the guest. >> >> Cao jin (2): >> enable multi-function hot-add >> remove function during multi-function hot-add >> >> hw/pci/pci.c | 10 ++++++++++ >> hw/pci/pci_host.c | 6 +++++- >> hw/pci/pcie.c | 38 +++++++++++++++++++++++++------------- >> 3 files changed, 40 insertions(+), 14 deletions(-) >> >> -- >> 2.1.0 > . > -- Yours Sincerely, Cao Jin