From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlyja-0001by-8W for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:31:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlyjX-0001lg-GR for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:31:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlyjX-0001lU-8o for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:31:11 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 07C08C1A5295 for ; Tue, 13 Oct 2015 12:31:11 +0000 (UTC) References: <1443930073-19359-1-git-send-email-eblake@redhat.com> <1443930073-19359-4-git-send-email-eblake@redhat.com> <87wpuywt89.fsf@blackfin.pond.sub.org> <56154945.5020107@redhat.com> <87lhb7fapt.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <561CF989.9050303@redhat.com> Date: Tue, 13 Oct 2015 06:31:05 -0600 MIME-Version: 1.0 In-Reply-To: <87lhb7fapt.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CAFeA6TKrSAncnMNsr6OP0Onu8SHEW4iD" Subject: Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CAFeA6TKrSAncnMNsr6OP0Onu8SHEW4iD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/13/2015 02:12 AM, Markus Armbruster wrote: >> Hmm, any test that has an empty .err and non-empty .out, but which doe= s >> not also have an TODO/FIXME stating that it is a bug, is worth checkin= g. >> So first, here's the list of non-empty .out files: >> >=20 > Actually, the point isn't to move the positive test to > qapi-schema-test.json, the point is to compile-test its generated code.= > Moving it to qapi-schema-test.json accomplishes that. However, we may > not want a single, monolithic positive test. Should we split up > qapi-schema-test.json instead? I don't know. Anyway, let's flush our > queue first. If we do split qapi-schema-test, it won't be until after my patches are flushed :) >=20 > Third case: the generated code isn't worth compile-testing; comparing > actual to expected .out suffices. >=20 > Let's sort your untagged tests into buckets: >=20 > Not worth compile-testing: > * comments.json > * include-simple.json > * include-repetition.json > * include-relpath.json > * indented-expr.json > * ident-with-escape.json >=20 > Not (completely) covered in qapi-schema-test.json: > * enum-empty.json > Not covered, but should be. Covered in v8: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02869.html > * flat-union-reverse-define.json > UserDefOne covers forward reference to struct base, UserDefFlatUnion > covers forward reference to union base, and UserDefFlatUnion2 covers > forward reference to member. We may want to cover forward reference > to the tag member's type. Covered in v8 >=20 > Covered: > * returns-int.json > 'user_def_cmd3' does the job. Cleaned up in v8 > * args-member-array.json > '__org.qemu_x-command' seems good enough. Not cleaned up yet, so I'll add it to my next round of subset C. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CAFeA6TKrSAncnMNsr6OP0Onu8SHEW4iD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWHPmJAAoJEKeha0olJ0NqEcgH/ji4xHZk94rKmsmrPKmNiAV5 z7aSAMCtxy5gymg64xbDUC1uiM0JcuM98eSw2qyO1h2boOcp/ZWaqvlwUw3gBZ0q +VLg2+ReXRrNJ9UXqRWJCjcxmswpmrikUySuSRorBHQcB4MlgS1YRPQzTnwA1X8N eZLn6JHUd6jJDvPjQ++qD2mM/tCDxcX2Vft7s08xIv3dvhr2XrK0QhxXNxRqs0dT OTLf+N0qgahg+7wVuVPcWAe/Kcthi5Y2/WOHzho9IGKCz+bEhRj+2zV4E8sDY3lh 5NWG7P9THXOmSOpAlrNbNw0LDbqjtqzlimiKNvlu70CWM5HyXwYHmIkZXsfaFeE= =jiKI -----END PGP SIGNATURE----- --CAFeA6TKrSAncnMNsr6OP0Onu8SHEW4iD--