From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39560)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZlzuW-0006HC-QG
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:46:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZlzuT-0003wg-BW
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:46:36 -0400
References: <1444664181-28023-1-git-send-email-akrowiak@linux.vnet.ibm.com>
	<561BD4CC.4020101@redhat.com>
	<20151013135136.5675e86b.cornelia.huck@de.ibm.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <561D0B35.7030309@redhat.com>
Date: Tue, 13 Oct 2015 16:46:29 +0300
MIME-Version: 1.0
In-Reply-To: <20151013135136.5675e86b.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] util/qemu-config: fix missing machine
 command line options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Tony Krowiak <akrowiak@linux.vnet.ibm.com>, qemu-stable@nongnu.org, qemu-devel@nongnu.org

On 10/13/2015 02:51 PM, Cornelia Huck wrote:
> On Mon, 12 Oct 2015 18:42:04 +0300
> Marcel Apfelbaum <marcel@redhat.com> wrote:
>
>> On 10/12/2015 06:36 PM, Tony Krowiak wrote:
>>> Commit 0a7cf217 ("util/qemu-config: fix regression of
>>> qmp_query_command_line_options") aimed to restore parsing of global
>>> machine options, but missed two: "aes-key-wrap" and
>>> "dea-key-wrap" (which were present in the initial version of that
>>> patch). Let's add them to the machine_opts again.
>>
>> Adding qemu-devel
>>
>> Hi,
>>
>> I thought I hunted them all, anyway, thanks for adding them.
>>
>> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
>
> Thanks.
>
> util/qemu-config.c yields -ENOMAINTAINER; any obvious tree for this to
> go through, or should I simply include this with the next batch of
> s390x patches (as these are s390x options)?
>

Just take it to your tree.
Thanks!
Marcel

>>
>>
>>>
>>> Fixes: 0a7cf217
>>> CC: Marcel Apfelbaum <marcel@redhat.com>
>>> CC: qemu-stable@nongnu.org
>>> Signed-off-by: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
>>> ---
>>>    util/qemu-config.c |    8 ++++++++
>>>    1 files changed, 8 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/util/qemu-config.c b/util/qemu-config.c
>>> index 5fcfd0e..687fd34 100644
>>> --- a/util/qemu-config.c
>>> +++ b/util/qemu-config.c
>>> @@ -219,6 +219,14 @@ static QemuOptsList machine_opts = {
>>>                .name = "suppress-vmdesc",
>>>                .type = QEMU_OPT_BOOL,
>>>                .help = "Set on to disable self-describing migration",
>>> +        },{
>>> +            .name = "aes-key-wrap",
>>> +            .type = QEMU_OPT_BOOL,
>>> +            .help = "enable/disable AES key wrapping using the CPACF wrapping key",
>>> +        },{
>>> +            .name = "dea-key-wrap",
>>> +            .type = QEMU_OPT_BOOL,
>>> +            .help = "enable/disable DEA key wrapping using the CPACF wrapping key",
>>>            },
>>>            { /* End of list */ }
>>>        }
>>>
>>
>