From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm2nB-0004os-Bt for qemu-devel@nongnu.org; Tue, 13 Oct 2015 12:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm2n8-00021C-0k for qemu-devel@nongnu.org; Tue, 13 Oct 2015 12:51:13 -0400 Received: from mga03.intel.com ([134.134.136.65]:11142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm2n7-000218-Ql for qemu-devel@nongnu.org; Tue, 13 Oct 2015 12:51:09 -0400 References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-5-git-send-email-guangrong.xiao@linux.intel.com> <20151013153409.4809c30c@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: <561D3506.1070904@linux.intel.com> Date: Wed, 14 Oct 2015 00:44:54 +0800 MIME-Version: 1.0 In-Reply-To: <20151013153409.4809c30c@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 04/32] acpi: add aml_mutex, aml_acquire, aml_release List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/13/2015 09:34 PM, Igor Mammedov wrote: > On Sun, 11 Oct 2015 11:52:36 +0800 > Xiao Guangrong wrote: > >> Implement Mutex, Acquire and Release terms which are used by NVDIMM _DSM method >> in later patch >> >> Signed-off-by: Xiao Guangrong >> --- >> hw/acpi/aml-build.c | 32 ++++++++++++++++++++++++++++++++ >> include/hw/acpi/aml-build.h | 3 +++ >> 2 files changed, 35 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 9fe5e7b..ab52692 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -1164,6 +1164,38 @@ Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name) >> return var; >> } >> >> +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMutex */ >> +Aml *aml_mutex(const char *name, uint8_t flags) > s/flags/sync_level/ Oops, will fix. > >> +{ >> + Aml *var = aml_alloc(); >> + build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */ >> + build_append_byte(var->buf, 0x01); /* MutexOp */ >> + build_append_namestring(var->buf, "%s", name); > > add assert here to check that reserved bits are 0 Good idea, will do.