From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm3bs-0005V0-FL for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:43:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm3bp-0003Wo-1V for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:43:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm3bo-0003Wh-QR for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:43:32 -0400 References: <1444710158-8723-1-git-send-email-eblake@redhat.com> <1444710158-8723-16-git-send-email-eblake@redhat.com> <87zizm6c67.fsf@blackfin.pond.sub.org> <561D24CA.7030804@redhat.com> <87mvvmvghf.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <561D42C3.1050207@redhat.com> Date: Tue, 13 Oct 2015 11:43:31 -0600 MIME-Version: 1.0 In-Reply-To: <87mvvmvghf.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uaeHl10MfHkoFkHV3Sw9px7CMeA1wpRnJ" Subject: Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uaeHl10MfHkoFkHV3Sw9px7CMeA1wpRnJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/13/2015 11:13 AM, Markus Armbruster wrote: >>> >>> I've come to the conclusion that we should get rid of the self-inflic= ted >>> pain before we attempt to detect all collisions. >> >> Then that sounds like I should try harder to get the kind/type naming,= >> the boxed base naming, and even the anonymous union naming all hoisted= >> into this subset, and spin a v9? >=20 > I can take PATCH 01-09,12 into my tree right away, with PATCH 07's two > redundant is_implicit() methods dropped, and PATCH 12's comment touched= > up. Okay. >=20 > I could take PATCH 10, but let's at least try to make a plan for > c_name() first. If we fail, I'll take the patch, perhaps less the % to= > + change, and we'll revisit c_name() later when we see more clearly. At this point, I'm not sure whether 10 disappears completely after the type/kind fix, so that alone is a good enough reason to leave 10 out of your tree for another round. >=20 > You want to move PATCH 11 to later in the queue, and I like that. >=20 > PATCH 13 needs a fix squashed in, and a few nits touched up. If you > want me to do that on commit, please propose a patch for me to squash > in. But a respin is probably easier for all. >=20 > PATCH 14 is fine, but it depends on 13. >=20 > I haven't finished review of PATCH 15-18. >=20 > Taken together, I think the easiest way forward is I take 01-09,12, and= > you respin the rest after we finish its review. Makes sense? >=20 Sounds like we're agreed then: take the obvious patches into your tree, and let me rework the tail of this subset on top of cleanups that reduce self-inflicted collisions. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uaeHl10MfHkoFkHV3Sw9px7CMeA1wpRnJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWHULDAAoJEKeha0olJ0NqeQAH/iqJePzj+fUmVSJ1IncOuDX8 6M9jx3v2jwhHU/n4xwEoBABj8yYkJwoWcIa9+uewiIrE+bcbsEODAJiK6n5yJ1Fn WROd7VM5VNQO01Xq4kr7nOLJbDK0QevExI83ZvqizGGR5apgbf5CsYY+NEITmN1S mc94GVpkl1wCF9U+ZLHEYkwfhEyUGXX42TbQiOJV9qsht+Xv39FL2ZLBK+IUdgcq mSdlK43Uw+Uqk0dou2zhdrUOB/FrHEDx3ouQ8o3tcbbQyqVtHT1V+KLp1Gfb/QJI tk9cNqO/t9vvGCMDdzTKurBizC7dboJkR5Em/3Mtu4I4ji6k+bDoY1vigFfj/AM= =UoYW -----END PGP SIGNATURE----- --uaeHl10MfHkoFkHV3Sw9px7CMeA1wpRnJ--