From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm3ie-0008MQ-9R for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:50:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm3ia-0006Fd-LE for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:50:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm3iZ-0006FO-Tz for qemu-devel@nongnu.org; Tue, 13 Oct 2015 13:50:32 -0400 References: <20151013171020.21325.27626.stgit@localhost> <20151013171107.21325.37133.stgit@localhost> From: Eric Blake Message-ID: <561D4466.9030803@redhat.com> Date: Tue, 13 Oct 2015 11:50:30 -0600 MIME-Version: 1.0 In-Reply-To: <20151013171107.21325.37133.stgit@localhost> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lBO81IKPIHlBq2bobWwbcHOtUSoo84PDa" Subject: Re: [Qemu-devel] [PATCHv18/8] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Gerd Hoffmann , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Stefan Hajnoczi , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lBO81IKPIHlBq2bobWwbcHOtUSoo84PDa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/13/2015 11:11 AM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > --- Interface review only. > +++ b/qapi/trace.json > @@ -64,3 +64,34 @@ > ## > { 'command': 'trace-event-set-state', > 'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bo= ol'} } > + > +## > +# @trace-event-get-cpu-state: > +# > +# Query the state of events in a given vCPU. > +# > +# @name: Event name pattern. > +# @vcpu: The vCPU to check. > +# > +# Returns: @TraceEventInfo of the matched events > +# > +# Since 2.2 2.5, not 2.2 > +## > +{ 'command': 'trace-event-get-cpu-state', > + 'data': {'name': 'str', 'vcpu': 'int'}, > + 'returns': ['TraceEventInfo'] } > + > +## > +# @trace-event-set-cpu-state: > +# > +# Set the dynamic state of events in a given vCPU. > +# > +# @name: Event name pattern. > +# @vcpu: The vCPU to act upon. > +# @enable: Whether to enable tracing. > +# @ignore-unavailable: #optional Do not match unavailable events with = @name. > +# > +# Since 2.2 2.5, not 2.2 > +## > +{ 'command': 'trace-event-set-cpu-state', > + 'data': {'name': 'str', 'vcpu': 'int', 'enable': 'bool', '*ignore-un= available': 'bool'} } This looks identical to trace-event-set-state, except that it now has a 'vcpu':'int' argument. Would it be any simpler to just modify the existing command: ## # @trace-event-set-state: =2E.. # @vcpu: #optional If provided, limit the state change to the given vcpu (default act on all vcpus) (since 2.5) # # Since 2.2 ## { 'command': 'trace-event-set-state', 'data': {'name': 'str', 'enable': 'bool', '*vcpu': 'int', '*ignore-unavailable': 'bool'} } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lBO81IKPIHlBq2bobWwbcHOtUSoo84PDa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWHURmAAoJEKeha0olJ0Nquu8H/jRYwjyiHq0FXIJGo0S+8nDc 8WtGAcjGA606+/NSTIvOjO83Gx28D6WCWWeBI86bxzPM+8C0nNoOp7dDl8FjA1Sd 9/n6BZ7zVwN4PebPPFQUx/BmZ3enHstXrbxuKcFLlZ21taFSsSp91UiM8BGFF80R dKXG07m/WQTjmKFNYb047sM//wyQNA2OVGFS8ZnB4SafRjgQwHHvrIE4SrMUDQQG AEp1shU3JFtZDNz0r8iZf0jsF93hjSK/3pOzxs5Gh9Mi034V9BV93QpyJWl02n+N vsXSPJf39elYCMsQerK4Y5eb3TKEBYBWHrseB0EGdKa5AT2NFX/V48N5BTm/vn4= =Fh33 -----END PGP SIGNATURE----- --lBO81IKPIHlBq2bobWwbcHOtUSoo84PDa--