From: Richard Henderson <rth@twiddle.net>
To: Sergey Fedorov <serge.fdrv@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test
Date: Wed, 14 Oct 2015 07:44:00 +1100 [thread overview]
Message-ID: <561D6D10.6040502@twiddle.net> (raw)
In-Reply-To: <561D09CC.9010903@gmail.com>
On 10/14/2015 12:40 AM, Sergey Fedorov wrote:
> Otherwise, "!(tb_end <= start || tb_start >= end)" condition
> check will fail
...
> So we either
> need to change the condition in tb_invalidate_phys_page_range() or do
> the PC advancement trick during translation, no matter can instructions
> cross a page boundary or not.
I think you're right.
The reason I've not seen an issue so far is that breakpoint_invalidate expands
the requested range to the entire page. So the failure to invalidate would
require the breakpoint to be at the page boundary.
r~
next prev parent reply other threads:[~2015-10-13 20:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 9:43 [Qemu-devel] [PULL 00/26] Do away with TB retranslation Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 01/26] tcg: Rename debug_insn_start to insn_start Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 02/26] target-*: Unconditionally emit tcg_gen_insn_start Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 03/26] target-*: Increment num_insns immediately after tcg_gen_insn_start Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test Richard Henderson
2015-10-09 13:34 ` Sergey Fedorov
2015-10-13 0:13 ` Richard Henderson
2015-10-13 8:13 ` Peter Maydell
2015-10-13 13:40 ` Sergey Fedorov
2015-10-13 20:44 ` Richard Henderson [this message]
2015-10-07 9:43 ` [Qemu-devel] [PULL 05/26] tcg: Allow extra data to be attached to insn_start Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 06/26] target-arm: Add condexec state " Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 07/26] target-i386: Add cc_op " Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 08/26] target-mips: Add delayed branch " Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 09/26] target-s390x: Add cc_op " Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 10/26] target-sh4: Add flags " Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 11/26] target-cris: Mirror gen_opc_pc into insn_start Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 12/26] target-sparc: Tidy gen_branch_a interface Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 13/26] target-sparc: Split out gen_branch_n Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 14/26] target-sparc: Remove gen_opc_jump_pc Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 15/26] target-sparc: Add npc state to insn_start Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 16/26] tcg: Merge cpu_gen_code into tb_gen_code Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 17/26] target-*: Drop cpu_gen_code define Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 18/26] tcg: Add TCG_MAX_INSNS Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 19/26] tcg: Pass data argument to restore_state_to_opc Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 20/26] tcg: Save insn data and use it in cpu_restore_state_from_tb Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 21/26] tcg: Remove gen_intermediate_code_pc Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 22/26] tcg: Remove tcg_gen_code_search_pc Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 23/26] tcg: Emit prologue to the beginning of code_gen_buffer Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 24/26] tcg: Allocate a guard page after code_gen_buffer Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 25/26] tcg: Check for overflow via highwater mark Richard Henderson
2015-10-07 9:43 ` [Qemu-devel] [PULL 26/26] tcg: Adjust CODE_GEN_AVG_BLOCK_SIZE Richard Henderson
2015-10-08 15:50 ` [Qemu-devel] [PULL 00/26] Do away with TB retranslation Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D6D10.6040502@twiddle.net \
--to=rth@twiddle.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).