From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm6Qc-0000TK-BI for qemu-devel@nongnu.org; Tue, 13 Oct 2015 16:44:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm6QZ-0001l5-4O for qemu-devel@nongnu.org; Tue, 13 Oct 2015 16:44:10 -0400 Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]:35238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm6QZ-0001kx-0A for qemu-devel@nongnu.org; Tue, 13 Oct 2015 16:44:07 -0400 Received: by qgt47 with SMTP id 47so25995070qgt.2 for ; Tue, 13 Oct 2015 13:44:06 -0700 (PDT) Sender: Richard Henderson References: <1444211031-11624-1-git-send-email-rth@twiddle.net> <1444211031-11624-5-git-send-email-rth@twiddle.net> <5617C252.6070104@gmail.com> <561C4CA4.9010506@twiddle.net> <561D09CC.9010903@gmail.com> From: Richard Henderson Message-ID: <561D6D10.6040502@twiddle.net> Date: Wed, 14 Oct 2015 07:44:00 +1100 MIME-Version: 1.0 In-Reply-To: <561D09CC.9010903@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 10/14/2015 12:40 AM, Sergey Fedorov wrote: > Otherwise, "!(tb_end <= start || tb_start >= end)" condition > check will fail ... > So we either > need to change the condition in tb_invalidate_phys_page_range() or do > the PC advancement trick during translation, no matter can instructions > cross a page boundary or not. I think you're right. The reason I've not seen an issue so far is that breakpoint_invalidate expands the requested range to the entire page. So the failure to invalidate would require the breakpoint to be at the page boundary. r~