Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

On 10/14/2015 01:32 AM, Markus Armbruster wrote:

>> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next.
> 
> Redone & pushed.
> 
> Summary of tweaks:
> * PATCH 01-06.5: unchanged
> * PATCH 07: your fixup to drop is_implicit() squashed in
> * PATCH 08: array info plumbing moved to PATCH 12
> * PATCH 09: trivially rebased
> * PATCH 12: revert your fixup, so we get the move we want, adjust commit
>   message accordingly, supply missing QAPISchemaArrayType.is_implicit()

You may also want to squash this into 12:

diff --git a/scripts/qapi.py b/scripts/qapi.py
index fd95864..1e01714 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -792,10 +792,9 @@ class QAPISchemaEntity(object):
         self.name = name
         # For explicitly defined entities, info points to the (explicit)
         # definition.  For builtins (and their arrays), info is None.
-        # For other arrays, info points to an explicit place that uses
-        # the array (there may be more than one such place).  For other
-        # implicitly defined entities, it points to the place that
-        # triggered the implicit definition.
+        # For implicitly defined entities, info points to a place that
+        # triggered the implicit definition (there may be more than one
+        # such place).
         self.info = info

     def c_name(self):

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]