From: Paolo Bonzini <pbonzini@redhat.com>
To: Sergey Fedorov <serge.fdrv@gmail.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] doc/rcu: fix g_free_rcu() usage example
Date: Wed, 14 Oct 2015 17:47:56 +0200 [thread overview]
Message-ID: <561E792C.1000805@redhat.com> (raw)
In-Reply-To: <1444837604-13712-1-git-send-email-serge.fdrv@gmail.com>
On 14/10/2015 17:46, Sergey Fedorov wrote:
> The first argument of g_free_rcu() is a pointer to a structure. But
> foo_reclaim is used as a function name in the previous example along
> with &foo as a pointer to the structure being reclaimed. Make the
> example consistent with the previous one.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> ---
> docs/rcu.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/rcu.txt b/docs/rcu.txt
> index 21ecb81..2f70954 100644
> --- a/docs/rcu.txt
> +++ b/docs/rcu.txt
> @@ -128,7 +128,7 @@ The core RCU API is small:
> the callback function is g_free, in particular, g_free_rcu can be
> used. In the above case, one could have written simply:
>
> - g_free_rcu(foo_reclaim, rcu);
> + g_free_rcu(&foo, rcu);
>
> typeof(*p) atomic_rcu_read(p);
>
>
Thanks, I've queued this patch, and I hope to send it out on Friday.
Paolo
prev parent reply other threads:[~2015-10-14 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 15:46 [Qemu-devel] [PATCH] doc/rcu: fix g_free_rcu() usage example Sergey Fedorov
2015-10-14 15:47 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E792C.1000805@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).