From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmOHd-0000Dl-ND for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:48:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmOHY-0000eM-L4 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:48:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmOHY-0000e7-F3 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:48:00 -0400 References: <1444837604-13712-1-git-send-email-serge.fdrv@gmail.com> From: Paolo Bonzini Message-ID: <561E792C.1000805@redhat.com> Date: Wed, 14 Oct 2015 17:47:56 +0200 MIME-Version: 1.0 In-Reply-To: <1444837604-13712-1-git-send-email-serge.fdrv@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] doc/rcu: fix g_free_rcu() usage example List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov , qemu-devel@nongnu.org Cc: Fam Zheng On 14/10/2015 17:46, Sergey Fedorov wrote: > The first argument of g_free_rcu() is a pointer to a structure. But > foo_reclaim is used as a function name in the previous example along > with &foo as a pointer to the structure being reclaimed. Make the > example consistent with the previous one. > > Signed-off-by: Sergey Fedorov > --- > docs/rcu.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/rcu.txt b/docs/rcu.txt > index 21ecb81..2f70954 100644 > --- a/docs/rcu.txt > +++ b/docs/rcu.txt > @@ -128,7 +128,7 @@ The core RCU API is small: > the callback function is g_free, in particular, g_free_rcu can be > used. In the above case, one could have written simply: > > - g_free_rcu(foo_reclaim, rcu); > + g_free_rcu(&foo, rcu); > > typeof(*p) atomic_rcu_read(p); > > Thanks, I've queued this patch, and I hope to send it out on Friday. Paolo