From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmOOk-0000Gy-RY for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmOOg-0003YR-J4 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:55:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmOOg-0003YN-E9 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:55:22 -0400 References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-15-git-send-email-pbonzini@redhat.com> <561BD204.7050307@redhat.com> <20151012154135.GF4886@var.bordeaux.inria.fr> <561E7A17.6050906@redhat.com> From: Eric Blake Message-ID: <561E7AE4.4040506@redhat.com> Date: Wed, 14 Oct 2015 09:55:16 -0600 MIME-Version: 1.0 In-Reply-To: <561E7A17.6050906@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Wo224pAmVXbVJL1KQwBnBhfeLw7ubkoL9" Subject: Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Samuel Thibault Cc: qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Wo224pAmVXbVJL1KQwBnBhfeLw7ubkoL9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/14/2015 09:51 AM, Paolo Bonzini wrote: >=20 >=20 > On 12/10/2015 17:41, Samuel Thibault wrote: >> Eric Blake, le Mon 12 Oct 2015 09:30:12 -0600, a =C3=A9crit : >>> Also, I assume that brlapi_perror() adds additional information to >>> the error message it prints, such as conversion of a brlapi-specific >>> error message in the same manner in which perror() converts errno and= in >>> which error_setg_errno() would be used. >> >> Yes. Such additional information is really useful to debug brlapi >> issues. >> >>> So I don't know if this >>> conversion is the best. But I'm unfamiliar with brlapi_* in general,= to >>> know if there is anything better to use, >> >> brlapi_error_t * brlapi_error_location(void); >> const char * brlapi_strerror(const brlapi_error_t *error); >> >> So brlapi_strerror(brlapi_error_location()) will return what you want,= >> i.e. the string that brlapi_error() would have printed. >=20 > Is it okay to squash this? I'd still like Samuel's confirmation, but from my point of view, that looks like enough to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Wo224pAmVXbVJL1KQwBnBhfeLw7ubkoL9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWHnrkAAoJEKeha0olJ0NqhacH/Rhji4qq4jAeEXm6t1Q8tJYL 4wO9OqYE7OSznNOKNA7MxHEtW46nIkXnvHJ3vTyzrjlRKlV22sMJmkvW1MAPTYVh 7TQpX4S4+osOU1bBw/4XqyOSiPOFejKZc1+nXz4tjVdUpDjSSp0nFzoJA1S3+uN9 5XudYQcsNusC70kTrxylx31tOjJq8pMtQ5stcSBCU5Uy0w7K4Wtv4DSfmIG3UnVM qVMloOlx5MiIKcOcSc7cyRtHszLnLUvinB19yAOFgkENFE1xEinnMRIXoOr35dxE XQrUe0odgK+nqrWkIW2gS0vJDccVBgKFQ6mWsOzZX7cXch0+ReetLjaUYZpDs0g= =yl98 -----END PGP SIGNATURE----- --Wo224pAmVXbVJL1KQwBnBhfeLw7ubkoL9--