From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmPH5-00022E-J3 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 12:51:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmPH2-000713-Ec for qemu-devel@nongnu.org; Wed, 14 Oct 2015 12:51:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmPH2-00070w-A0 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 12:51:32 -0400 References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com> <1444637004-20195-15-git-send-email-pbonzini@redhat.com> <561BD204.7050307@redhat.com> <20151012154135.GF4886@var.bordeaux.inria.fr> <561E7A17.6050906@redhat.com> <20151014163440.GY2609@var.bordeaux.inria.fr> From: Paolo Bonzini Message-ID: <561E880E.5090000@redhat.com> Date: Wed, 14 Oct 2015 18:51:26 +0200 MIME-Version: 1.0 In-Reply-To: <20151014163440.GY2609@var.bordeaux.inria.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: qemu-devel@nongnu.org, armbru@redhat.com On 14/10/2015 18:34, Samuel Thibault wrote: > Paolo Bonzini, le Wed 14 Oct 2015 17:51:51 +0200, a =E9crit : >> >> >> On 12/10/2015 17:41, Samuel Thibault wrote: >>> Eric Blake, le Mon 12 Oct 2015 09:30:12 -0600, a =E9crit : >>>> Also, I assume that brlapi_perror() adds additional information to >>>> the error message it prints, such as conversion of a brlapi-specific >>>> error message in the same manner in which perror() converts errno an= d in >>>> which error_setg_errno() would be used. >>> >>> Yes. Such additional information is really useful to debug brlapi >>> issues. >>> >>>> So I don't know if this >>>> conversion is the best. But I'm unfamiliar with brlapi_* in general= , to >>>> know if there is anything better to use, >>> >>> brlapi_error_t * brlapi_error_location(void); >>> const char * brlapi_strerror(const brlapi_error_t *error); >>> >>> So brlapi_strerror(brlapi_error_location()) will return what you want= , >>> i.e. the string that brlapi_error() would have printed. >> >> Is it okay to squash this? >=20 > Yes, this looks right. Building with brlapi-dev installed would confirm > for sure that it builds, of course :) That I checked. :) Paolo