From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmPsE-0007eD-8i for qemu-devel@nongnu.org; Wed, 14 Oct 2015 13:29:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmPsD-0003s5-AW for qemu-devel@nongnu.org; Wed, 14 Oct 2015 13:29:58 -0400 References: From: Max Reitz Message-ID: <561E910C.2090204@redhat.com> Date: Wed, 14 Oct 2015 19:29:48 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fBT8aj2hQ8qMBarll75cMs8T59sJd12Jk" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-block@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fBT8aj2hQ8qMBarll75cMs8T59sJd12Jk Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 14.10.2015 15:16, Jeff Cody wrote: > This is a precursor to making bdrv_find_node() static, and internal > to block.c >=20 > To find a BlockDriverState interface, it can be done via blk_by_name(),= > bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place > of the other two, in the instances where we are only concerned with > the BlockDriverState. >=20 > There is no benefit in calling bdrv_find_node() directly. This patch > replaces all calls to bdrv_find_node() outside of block.c with > bdrv_lookup_bs(). >=20 > Signed-off-by: Jeff Cody > --- > block/block-backend.c | 2 +- > block/mirror.c | 2 +- > block/write-threshold.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz --fBT8aj2hQ8qMBarll75cMs8T59sJd12Jk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWHpEMAAoJEDuxQgLoOKytO/AH/RAm/KMbS4yCcK7GbRMpavC5 b+lcXB86rVdevtCAo4bN5GK15vizeMnvDrGb0d0+P8BYO/lIgDliPkxcQVIWE9px yUnEL0yT8SeWjGCtQTsuJ715qxC5YwBegpmYb6VcNDbo9NOTX15bFD0M8DfzT/Pa oAHl5lfMYLAjE0iqDJkV5P0AJMjiFwDXIUWFdfJtbFA4PgIUZrwua19MQtdMOcg8 l5mnURivquiE3fEchhGnJo8NWk8MPjBqJcByAhAFGu0zp+OGFwFxgoJUEH2w8us0 fjvUrVCgXkJrmhz5kFdZ+WW1N7pahkcducAjc9Yo7LubuXQUfkBbtMHB68bMB2s= =SPjH -----END PGP SIGNATURE----- --fBT8aj2hQ8qMBarll75cMs8T59sJd12Jk--